← Back to issue list

Replace proxy environment variables if fetch service is enabled

View original Github issue

Metadata

Project
craft-application
Number
#492
Type
issue
State
closed
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

No change was needed: fetch-service proxy replacement was already implemented in commit bdb374c7 via PR #11; #492 was closed as unnecessary.

Resolution: closed not a bug

Reason: The maintainer closed the issue after confirming the requested behavior was already implemented in commit bdb374c7, associated with PR #11.

Evaluated by: mr-cal-bot

No scores available.

Issue body

### What needs to get done If a run is using the fetch service, the ProviderService should replace proxy environment variables with going to fetch service instead: https://github.com/canonical/craft-application/blob/c971a6098d5c3b93787bca217090af885088e626/craft_application/services/provider.py#L96-L98 ### Why it needs to get done Prevent proxy environment variables from bypassing the fetch service or breaking things.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed not a bug No change was needed: fetch-service proxy replacement was already implemented in commit bdb374c7 via PR #11; #492 was closed as unnecessary.
stealth/space-bunny-alpha — closed resolved Proxy replacement was already implemented in fetch-service build-instance configuration (commit bdb374c7, PR #11); maintainer closed #492 as unnecessary.
qwen/qwen3.6-35b-a3b — — The requested proxy environment variable replacement was already implemented. The author closed the issue after realizing the functionality existed, leaving it abandoned without further changes.
qwen/qwen3.6-35b-a3b — — Closed as already implemented. The author confirmed proxy environment variable replacement for the fetch service was already in place and withdrew the request.

Update history

No update history recorded yet.

Related work

Related issues

Issue Project State Summary Similarity
#1096 Pass proxy env vars to the fetch service craft-application closed Fetch-service startup now forwards host proxy settings, including HTTP(S)_PROXY and NO_PROXY variants; implemented in commit 826edb3f via PR #1091.
79%