← Back to issue list

fix(config): wrap snap config handler in snap check

View original Github issue

Metadata

Project
craft-application
Number
#499
Type
pull request
State
merged
Author
lengau
Labels
Created
Updated
Closed

Current evaluation

Merged a fix wrapping the snap config handler in a snap environment check to prevent execution errors outside snaps. Approved by two reviewers, passed CI, and introduced 12 lines across two files.

Suggested action:

No scores available.

Issue body

See: https://github.com/albertodonato/snap-helpers/issues/21#issuecomment-2386615504 - [ ] Have you followed the guidelines for contributing? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `tox`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged a fix wrapping the snap config handler in a snap environment check to prevent execution errors outside snaps. Approved by two reviewers, passed CI, and introduced 12 lines across two files.
qwen3.6-35b-a3b-mtp-q6 Merged a fix wrapping the snap config handler in a snap check, resolving snap-helpers issue #21. Authored by maintainer lengau, the change was successfully integrated.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#497 fix(config): warn on snapctl errors craft-application merged Merged a configuration fix that warns on snapctl errors. Approved by two reviewers, the change adds 32 lines across two files and addresses pending review feedback.
79%
#3974 snap config: catch more errors when config cannot be retrieved snapcraft merged Merged improvements to snap configuration error handling. Follows up on PR #3971 to catch additional retrieval failures reported by users. Approved by one reviewer, passed CI checks, and updated four files (+30/-10).
73%
#3317 plugin handler: properly handle snapcraftctl errors snapcraft merged Merged fix for plugin handler to properly catch snapcraftctl errors. Replaced specific exception handling with a broad catch in the scriptlet runner to prevent silent failures and redundant output. Approved, passed CI, and increased coverage.
71%
#171 fix(snap): update config dir in post-refresh hook fetch-service merged Merged a fix updating the ACL configuration file path in the snap post-refresh hook. Approved by three reviewers and passed CI checks.
70%
#3971 snap config: do not crash when config cannot be retrieved snapcraft merged Merged. Fixed a crash in get_snap_config() when snapd is unavailable by catching and logging errors. Approved by reviewer and passed CI checks.
70%