← Back to issue list

feat: report fetch-service rejections

View original Github issue

Metadata

Project
craft-application
Number
#516
Type
pull request
State
merged
Author
tigarmo
Labels
—
Created
Updated
Closed

Current evaluation

Merged as commit 480dee1a (with 5d313497 parsing artifact rejection reasons): FetchService now reports fetch-service-rejected dependencies (URLs + reasons) when writing the Craft manifest. Closes #507.

Resolution: closed resolved

Reason: PR #516 was merged into craft-application main as commit 480dee1a, approved by two reviewers with no CI failures. SessionArtifactManifest gained 'rejected'/'rejection_reasons' fields and fetch.py emits a permanent progress message listing each rejected artifact's URL and reasons, plus a warning that the build would fail on strict sessions.

Evaluated by: mr-cal-bot

No scores available.

Issue body

This PR is split over two commits; the first one augments the model to hold the rejection info, and the second one actually reports that info. ---- When creating the Craft manifest the FetchService will now also print a report of those dependencies that were rejected by the fetch-service. This includes the dependencies' urls and the list of rejection reasons. Fixes #507

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged as commit 480dee1a (with 5d313497 parsing artifact rejection reasons): FetchService now reports fetch-service-rejected dependencies (URLs + reasons) when writing the Craft manifest. Closes #507.
stealth/space-bunny-alpha — closed resolved Merged in commit 480dee1a to report rejected dependency URLs and rejection reasons when creating Craft manifests, resolving #507.
qwen/qwen3.6-35b-a3b — — Merged feature adding rejection reporting to Craft manifest generation. FetchService now outputs dependency URLs and rejection reasons, resolving issue #507. Approved by two reviewers with passing CI checks.

Update history

No update history recorded yet.

Related work

  • Likely Fixed By: craft-application#507 (confidence 99%)

    Issue #507 asked to report which fetch-service artifacts would be rejected in permissive sessions; the PR body states 'Fixes #507' and that issue is now closed.

  • Related To: craft-application#5d313497 (confidence 85%)

    First of the two commits in the PR, adding rejection-reason parsing to SessionArtifactManifest.from_session_report.

Related issues

Issue Project State Summary Similarity
#481 feat: create the final craft manifest craft-application merged Merged in craft-application#481 via 60f3188a, combining packed-artifact metadata with FetchService dependency details in the final Craft manifest.
72%