← Back to issue list

feat: add ordered to the add_command_group API

View original Github issue

Metadata

Project
craft-application
Number
#574
Type
pull request
State
merged
Author
dariuszd21
Labels
—
Created
Updated
Closed

Current evaluation

PR #574 by dariuszd21 was merged as commit 46ee5405, adding an `ordered` keyword argument to Application.add_command_group so command ordering in help output can be persisted; approved with 2 reviewers.

Resolution: closed resolved

Reason: The pull request was merged into main as commit 46ee5405 ('feat: add ordered to the add_command_group API (#574)') with review approval and no unresolved comments. The follow-up Ruff lint failures it mentioned were fixed separately in #580 (commit 97347705). The `ordered: bool = False` parameter is present in craft_application/application.py on current main.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [ ] Have you followed the guidelines for contributing? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `tox`? Allow persisting ordering in help, when commands are registered through `add_command_group` API. Linter issues are unrelated (they're from `ruff` update), fixed in #580

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved PR #574 by dariuszd21 was merged as commit 46ee5405, adding an `ordered` keyword argument to Application.add_command_group so command ordering in help output can be persisted; approved with 2 reviewers.
stealth/space-bunny-alpha — closed resolved Merged #574 as commit 46ee5405, adding an ordered option to add_command_group so registered command groups preserve ordering in help output.
stealth/space-bunny-alpha — closed resolved Merged in #574 as commit 46ee5405, adding an ordered option to add_command_group to preserve command ordering in help. Unrelated Ruff fixes landed separately in #580.
stealth/space-bunny-alpha — closed resolved Merged #574 in commit 46ee5405, adding an ordered option to add_command_group so command ordering persists in help output.
qwen/qwen3.6-35b-a3b — — Merged. Introduces an ordered parameter to the add_command_group API to persist command ordering in help output. Approved by two reviewers, passed CI and tests. Unrelated linter fixes were handled separately.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/craft-application#580 (confidence 92%)

    Follow-up PR referenced in the body to fix unrelated lint issues from the Ruff update; merged as commit 97347705.

Related issues

Issue Project State Summary Similarity
#195 Allow the application to choose the order of commands within a command group craft-cli closed Implemented via merged PR #196 (commit a88b353): added CommandGroup.ordered flag so apps can keep declared command order in help output instead of alphabetising; issue closed as resolved.
73%
#196 feat: allow the application to choose the help order of commands craft-cli merged Merged PR #196 as commit a88b353, adding application-configurable command help order and fixing #195.
72%