← Back to issue list

feat: allow use of interceptable `mknod` in `ProviderService`

View original Github issue

Metadata

Project
craft-application
Number
#607
Type
pull request
State
open
Author
mattculler
Labels
—
Created
Updated
Closed
—

Current evaluation

Small PR (+15/-4, 3 files) to pass craft-providers' new intercept_mknod argument through ProviderService's LXDProvider call. Open 593 days, last activity 2 days ago. Review status: changes_requested with 2 unresolved comments. CI passing.

Suggested action: needs review

Reason: The PR has changes_requested from 2 reviewers with 2 unresolved comments, so the author needs to address that feedback before it can proceed. The upstream dependency (craft-providers#717) is already merged and the current provider.py still lacks the intercept_mknod parameter, confirming the change is still needed. Recent activity (2 days ago) and all-passing CI indicate the PR is live and actionable.

Impact: 35 Quick Win: 29.75 Staleness: 25 Complexity: 15 Confidence: 78

Issue body

- [ ] Have you followed the guidelines for contributing? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `tox`? ----- Make use of `craft_providers`'s new `intercept_mknod` argument to `LXDProvider`. https://github.com/canonical/craft-providers/pull/717

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.8-27b
Impact: 35
Quick Win: 29.75
Staleness: 25
Complexity: 15
Confidence: 78
needs review Small PR (+15/-4, 3 files) to pass craft-providers' new intercept_mknod argument through ProviderService's LXDProvider call. Open 593 days, last activity 2 days ago. Review status: changes_requested with 2 unresolved comments. CI passing.
qwen/qwen3.6-35b-a3b
Staleness: 85
Complexity: 15
Confidence: 80
close stale Adds interceptable mknod support to ProviderService via craft-providers. Currently has 7 unresolved review comments, failing CI checks, and has been inactive for over a year.
qwen3.6-35b-a3b-mtp-q6
Staleness: 95
Complexity: 25
Confidence: 80
close stale Updates ProviderService to use the intercept_mknod argument from craft-providers. Inactive for over a year with unresolved integration tests linked to another PR.
qwen3.6-35b-a3b-mtp-q6
Staleness: 85
Complexity: 20
Confidence: 75
close stale Enables interceptable mknod in ProviderService by leveraging craft_providers new intercept_mknod argument for LXDProvider. Currently inactive, awaiting integration test fixes from a related PR.

Update history

Date Change
updated

Related work

  • Related To: canonical/craft-providers#717 (confidence 95%)

    Upstream PR that added the intercept_mknod parameter to LXDProvider; already merged (commit 6ceb498). This PR is the craft-application-side follow-up to use that new argument.

  • Related To: canonical/craft-application#587 (confidence 70%)

    Referenced in the PR comment as fixing failing integration tests; already merged. May have resolved some of the CI concerns for this PR.

Related issues

No related issues found above the similarity threshold.