← Back to issue list

feat: allow use of interceptable `mknod` in `ProviderService`

View original Github issue

Metadata

Project
craft-application
Number
#607
Type
pull request
State
open
Author
mattculler
Labels
—
Created
Updated
Closed
—

Current evaluation

Wires ProviderService’s LXD setup to craft-providers’ new intercept_mknod argument, with tests. No failures are reported, but two requested-change reviews remain unresolved and many checks are pending.

Suggested action: keep open

Reason: Review status remains changes_requested with 2 unresolved comments, so the change is not ready for approval. The author said prior integration-test failures would be fixed by merged craft-application#587; upstream craft-providers#717 is also merged, but CI has not fully completed and no response to the review comments is shown.

Evaluated by: mr-cal-bot

Impact: 35 Quick Win: 8 Complexity: 24 Confidence: 88 Actionability: 30

Issue body

- [ ] Have you followed the guidelines for contributing? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `tox`? ----- Make use of `craft_providers`'s new `intercept_mknod` argument to `LXDProvider`. https://github.com/canonical/craft-providers/pull/717

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha
Impact: 35
Quick Win: 8
Complexity: 24
Confidence: 88
Actionability: 30
keep open Wires ProviderService’s LXD setup to craft-providers’ new intercept_mknod argument, with tests. No failures are reported, but two requested-change reviews remain unresolved and many checks are pending.
stealth/space-bunny-alpha
Impact: 25
Quick Win: 8
Complexity: 18
Confidence: 72
Actionability: 40
needs review Wires craft-providers' new intercept_mknod option into ProviderService's LXDProvider (+15/-4, 3 files). CI checks pass, but review is changes_requested with 2 unresolved comments; idle 33 days.
qwen/qwen3.6-35b-a3b
Impact: 30
Quick Win: 15
Complexity: 15
Confidence: 75
Actionability: 60
needs review Adds intercept_mknod argument to LXDProvider in ProviderService, using craft-providers PR #717. Small change (+15/-4). Has 2 unresolved review comments, CI passing, last activity 22 days ago.
qwen/qwen3.8-27b
Impact: 35
Quick Win: 30
Staleness: 25
Complexity: 15
Confidence: 78
needs review Small PR (+15/-4, 3 files) to pass craft-providers' new intercept_mknod argument through ProviderService's LXDProvider call. Open 593 days, last activity 2 days ago. Review status: changes_requested with 2 unresolved comments. CI passing.
qwen/qwen3.6-35b-a3b
Staleness: 85
Complexity: 15
Confidence: 80
close stale Adds interceptable mknod support to ProviderService via craft-providers. Currently has 7 unresolved review comments, failing CI checks, and has been inactive for over a year.
qwen3.6-35b-a3b-mtp-q6
Staleness: 95
Complexity: 25
Confidence: 80
close stale Updates ProviderService to use the intercept_mknod argument from craft-providers. Inactive for over a year with unresolved integration tests linked to another PR.

Update history

Date Change
updated

Related work

  • Related To: craft-providers#717 (confidence 100%)

    Merged upstream PR that added the LXDProvider intercept_mknod argument used here.

  • Likely Fixed By: craft-application#587 (confidence 95%)

    The author explicitly identified this merged PR as the fix for earlier integration-test failures.

Related issues

Issue Project State Summary Similarity
#717 feat: mknod intercepts now configurable from LXDProvider craft-providers merged Merged #717, adding an intercept_mknod option to LXDProvider so dependent applications can enable or disable LXD mknod interception; released in 2.2.0.
75%