← Back to issue list

feat(ProviderService): deprecate work_dir on instance

View original Github issue

Metadata

Project
craft-application
Number
#649
Type
pull request
State
open
Author
lengau
Labels
—
Created
Updated
Closed
—

Current evaluation

Deprecates work_dir parameter on ProviderService.instance() in favor of self._work_dir. Approved but stale (451 days inactive) with failing CI (fast tests, lint, min deps). Related to open issue #606.

Suggested action: needs review

Reason: PR is approved with 0 unresolved comments but has 5 failing CI checks (fast tests on jammy/noble, minimum dependencies, lint/files, snap-tests) after 451 days of inactivity, indicating it needs rebasing against the current codebase. The related issue #606 (remove work_dir from ProviderService methods) is still open, so the deprecation step remains relevant.

Impact: 15 Quick Win: 12.0 Staleness: 75 Complexity: 20 Confidence: 80

Issue body

This is not needed since the ProviderService has a work_dir instance attribute. Does not remove it though, as that will need to wait for a major release. Related to #606 (but not yet a fix). - [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint && make test`? - [x] Have you added an entry to the changelog (`docs/reference/changelog.rst`)? ---

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.8-27b
Impact: 15
Quick Win: 12.0
Staleness: 75
Complexity: 20
Confidence: 80
needs review Deprecates work_dir parameter on ProviderService.instance() in favor of self._work_dir. Approved but stale (451 days inactive) with failing CI (fast tests, lint, min deps). Related to open issue #606.
qwen/qwen3.6-35b-a3b
Staleness: 85
Complexity: 15
Confidence: 75
close stale Deprecates the work_dir instance attribute in ProviderService to eliminate redundancy. The change is approved but has been inactive for over a year with unresolved CI failures.
qwen3.6-35b-a3b-mtp-q6
Staleness: 75
Complexity: 15
Confidence: 80
needs review Deprecates the work_dir instance parameter in ProviderService since the class already has a work_dir attribute. The PR has been inactive for over a year with no maintainer feedback or CI status.
qwen3.6-35b-a3b-mtp-q6
Staleness: 85
Complexity: 10
Confidence: 85
needs review Deprecates the instance work_dir parameter in ProviderService since the class already exposes this attribute. Removal is deferred to a major release. Currently inactive with no comments or recent updates.

Update history

No update history recorded yet.

Related work

  • Related To: craft-application#606 (confidence 90%)

    PR body explicitly states 'Related to #606 (but not yet a fix)'. Issue #606 is still open and requests removing work_dir arguments from ProviderService methods.

Related issues

Issue Project State Summary Similarity
#606 Remove `work_dir` argument from `ProviderService` methods craft-application open Refactor request to remove redundant work_dir arguments from ProviderService methods in favor of self._work_dir. Open since 593 days ago with only a bot ticket sync and a failed reproduction attempt; no labels or maintainer triage.
73%