← Back to issue list

feat(ProviderService): deprecate work_dir on instance

View original Github issue

Metadata

Project
craft-application
Number
#649
Type
pull request
State
open
Author
lengau
Labels
—
Created
Updated
Closed
—

Current evaluation

Maintainer PR deprecating the redundant work_dir argument to ProviderService.instance() (emits a deprecation warning, keeps the arg for a future major release). Approved with no unresolved comments, but stale and CI is red.

Suggested action: needs review

Reason: The change is small, approved (1 reviewer, 0 unresolved comments) and still relevant: craft_application/services/provider.py at current HEAD (7.4.1) still declares `work_dir: pathlib.Path` on `instance()` and passes it to `_get_instance_name()`/`_clean_instance()`, and issue #606 remains open. However, the PR is 595 days old with no activity for 482 days and CI is failing on 'lint / files', 'test / Fast tests (jammy/noble)', 'test / Minimum dependencies' and 'snap-tests (google:)' despite slow tests passing, so it needs a rebase onto current main and a re-run of CI before it can land. Closing as stale is not appropriate because the work_dir parameter still exists upstream (and commit 3334f13e 'chore!: remove deprecated APIs' did not remove it), so the change is not obsolete.

Evaluated by: mr-cal-bot

Impact: 28 Quick Win: 7 Complexity: 15 Confidence: 70 Actionability: 30

Issue body

This is not needed since the ProviderService has a work_dir instance attribute. Does not remove it though, as that will need to wait for a major release. Related to #606 (but not yet a fix). - [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint && make test`? - [x] Have you added an entry to the changelog (`docs/reference/changelog.rst`)? ---

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha
Impact: 28
Quick Win: 7
Complexity: 15
Confidence: 70
Actionability: 30
needs review Maintainer PR deprecating the redundant work_dir argument to ProviderService.instance() (emits a deprecation warning, keeps the arg for a future major release). Approved with no unresolved comments, but stale and CI is red.
qwen/qwen3.6-35b-a3b
Impact: 20
Quick Win: 4
Complexity: 25
Confidence: 60
Actionability: 30
close stale Deprecates work_dir parameter on ProviderService instance; approved by 1 reviewer but CI has failing checks (snap-tests, fast tests, lint/files); PR inactive for 471 days.
qwen/qwen3.8-27b
Impact: 15
Quick Win: 12
Staleness: 75
Complexity: 20
Confidence: 80
needs review Deprecates work_dir parameter on ProviderService.instance() in favor of self._work_dir. Approved but stale (451 days inactive) with failing CI (fast tests, lint, min deps). Related to open issue #606.
qwen/qwen3.6-35b-a3b
Staleness: 85
Complexity: 15
Confidence: 75
close stale Deprecates the work_dir instance attribute in ProviderService to eliminate redundancy. The change is approved but has been inactive for over a year with unresolved CI failures.
qwen3.6-35b-a3b-mtp-q6
Staleness: 75
Complexity: 15
Confidence: 80
needs review Deprecates the work_dir instance parameter in ProviderService since the class already has a work_dir attribute. The PR has been inactive for over a year with no maintainer feedback or CI status.

Update history

No update history recorded yet.

Related work

  • Related To: craft-application#606 (confidence 90%)

    The PR body explicitly states 'Related to #606 (but not yet a fix)'; that open issue tracks removing work_dir arguments from ProviderService methods.

Related issues

Issue Project State Summary Similarity
#606 Remove `work_dir` argument from `ProviderService` methods craft-application open ProviderService stores work_dir in __init__ but instance() still requires its own work_dir while clean_instances() uses self._work_dir; refactor requested to remove method argument. No maintainer triage yet.
74%