← Back to issue list

feat: add line number to error messages

View original Github issue

Metadata

Project
craft-application
Number
#664
Type
pull request
State
open
Author
alesancor1
Labels
—
Created
Updated
Closed
—

Current evaluation

Adds line numbers to error messages across 9 files (+157/-14). Pending review, 1 unresolved comment, no CI results, no changelog entry. Last activity 451 days ago (2025-03-17).

Suggested action: needs review

Reason: The PR was marked ready for review on 2025-03-17 but has had no maintainer engagement for ~15 months and has 1 unresolved review comment. The feature (line numbers in error messages) is still relevant — no commit in the repo implements it (searched for 'line number', 'line_number', 'lineno' with no matches), and related error-improvement work (#927, #433, #427) touched adjacent areas but did not add line numbers. However, the diff spans 9 files and the project service has been heavily refactored since (multi-base #812, Pro support #1047, deprecated API removal #1078), so the PR likely needs rebasing before it can be merged. A maintainer should review whether the approach still fits the current error-handling architecture.

Impact: 40 Quick Win: 22.0 Staleness: 85 Complexity: 45 Confidence: 55

Issue body

- [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint && make test`? - [ ] Have you added an entry to the changelog (`docs/reference/changelog.rst`)? ---

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.8-27b
Impact: 40
Quick Win: 22.0
Staleness: 85
Complexity: 45
Confidence: 55
needs review Adds line numbers to error messages across 9 files (+157/-14). Pending review, 1 unresolved comment, no CI results, no changelog entry. Last activity 451 days ago (2025-03-17).
qwen/qwen3.6-35b-a3b
Staleness: 85
Complexity: 30
Confidence: 80
close stale Adds line numbers to error messages across 9 files. The PR has been inactive for over a year with no maintainer feedback, missing changelog entry, and one unresolved review comment.
qwen3.6-35b-a3b-mtp-q6
Staleness: 92
Complexity: 15
Confidence: 80
close stale Adds line numbers to error messages. Open for over 16 months with no maintainer feedback. Lacks changelog entry and has been inactive for nearly 13 months, making it outdated and likely conflicting with current codebase changes.
qwen3.6-35b-a3b-mtp-q6
Staleness: 85
Complexity: 10
Confidence: 70
close stale Adds line numbers to error messages for better debugging. Submitted by an external contributor and marked ready for review, but has been inactive for over a year. Currently awaiting maintainer review and a changelog entry.

Update history

No update history recorded yet.

Related work

  • Related To: craft-application#927 (confidence 60%)

    feat(errors): include input value on pydantic errors — same area of improving error message detail, but does not add line numbers.

  • Related To: craft-application#433 (confidence 55%)

    fix: provide more info in YAML errors — earlier effort to enrich YAML error messages; this PR extends that direction with line numbers.

Related issues

No related issues found above the similarity threshold.