← Back to issue list

DO NOT MERGE: Review PR for ProjectService and Pytest plugin

View original Github issue

Metadata

Project
craft-application
Number
#672
Type
pull request
State
closed
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Closed unmerged as an abandoned documentation review; 34 review comments remained unresolved, and fixes were explicitly deferred to a separate PR.

Resolution: closed stale

Reason: The PR was marked "DO NOT MERGE," received no review or CI activity, and was closed with all 34 review comments unresolved. The reviewed components had already landed separately in #646 (16a20e36) and #653 (5d7a6fe0).

Evaluated by: mr-cal-bot

No scores available.

Issue body

This PR is for reviewing documentation on the hybrid-commands feature branch. Fixes should be collected into another PR. Stuff to review here: - [conf.py](https://github.com/canonical/craft-application/pull/672/files#diff-85933aa74a2d66c3e4dcdf7a9ad8397f5a7971080d34ef1108296a7c6b69e7e3) - [Changelog](https://canonical-craft-application--672.com.readthedocs.build/en/672/reference/changelog.html) ([source](https://github.com/canonical/craft-application/pull/672/files#diff-eb29f8aa8710b23f62787ed2d4a3049c01d0d1859b625b20a11e2b523e525694)) - [pytest plugin](https://canonical-craft-application--672.com.readthedocs.build/en/672/reference/pytest-plugin.html) ([rST source](https://github.com/canonical/craft-application/pull/672/files#diff-7ca2652cee161d24a9cb39f11e79948ea5147758c2eb9200aa38635339d6c48b), [python source](https://github.com/canonical/craft-application/pull/672/files#diff-b8ce476739a9d553280b9f62d837ade9807a99c30f679cbafea808f1f98cd518)) - [`ProjectService`](https://canonical-craft-application--672.com.readthedocs.build/en/672/reference/services/project.html#) ([rST source](https://github.com/canonical/craft-application/pull/672/files#diff-8e49a7f0ac74be30a10132028c1931087113ad48d71fc1d1998629150c24a810), [python source](https://github.com/canonical/craft-application/pull/672/files#diff-5a1e547ec3a0d86ebd396803eabf6624306b1a16cef192d4c55487897a9d8ea6)) There will be more later, but this is what's currently on that feature branch. CRAFT-4305

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed stale Closed unmerged as an abandoned documentation review; 34 review comments remained unresolved, and fixes were explicitly deferred to a separate PR.
stealth/space-bunny-alpha — closed stale Closed unmerged as an abandoned documentation review, with no feedback, 34 unresolved comments, and fixes deferred to a separate PR.
stealth/space-bunny-alpha — closed stale Review-only PR #672 was closed unmerged after 22 days of inactivity, with 34 unresolved comments; fixes were deferred to a separate PR. ProjectService work later landed in #674.
qwen/qwen3.6-35b-a3b — — Closed without merging. Marked for documentation review, but received no feedback and accumulated 34 unresolved comments. Abandoned after ~22 days of inactivity, with fixes deferred to a separate PR.

Update history

No update history recorded yet.

Related work

Related issues

No related issues found above the similarity threshold.