← Back to issue list

chore: make _app_preprocess_project non-static

View original Github issue

Metadata

Project
craft-application
Number
#689
Type
pull request
State
closed
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

PR #689 was closed unmerged after a workaround was found; _app_preprocess_project remains static and the proposed one-line API change was abandoned.

Resolution: closed stale

Reason: The maintainer closed PR #689 on 2025-04-01, stating, "Closing because we found a workaround." No superseding PR or commit was identified, and the method remains static in the current code.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint && make test`? - [x] Have you added an entry to the changelog (`docs/reference/changelog.rst`)? --- Snapcraft allows a parse-info in parts entries. It's not allowed by craft-parts so snapcraft pops the key from the raw dictionary, saves it, and passes it to the package service where it is consumed. This method is the best place to do that, but it needs to be non-static.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed stale PR #689 was closed unmerged after a workaround was found; _app_preprocess_project remains static and the proposed one-line API change was abandoned.
stealth/space-bunny-alpha — closed stale Closed unmerged after a workaround was found; the one-line change to make _app_preprocess_project non-static was abandoned.
qwen/qwen3.6-35b-a3b — — Closed without merging after the author found a workaround. The change to make _app_preprocess_project non-static was approved and passed CI but was ultimately abandoned.

Update history

No update history recorded yet.

Related issues

No related issues found above the similarity threshold.