← Back to issue list

fix(spread): include project in craft-spread model

View original Github issue

Metadata

Project
craft-application
Number
#726
Type
pull request
State
merged
Author
lengau
Labels
Created
Updated
Closed

Current evaluation

Merged a fix to include the project field in the craft-spread model. Approved by two reviewers, passed most CI checks despite one failing test, and merged by maintainer lengau. Modified two files.

Suggested action:

No scores available.

Issue body

- [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint && make test`? - [x] Have you added an entry to the changelog (`docs/reference/changelog.rst`)? ---

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged a fix to include the project field in the craft-spread model. Approved by two reviewers, passed most CI checks despite one failing test, and merged by maintainer lengau. Modified two files.
qwen3.6-35b-a3b-mtp-q6 Merged a fix to include the project field in the craft-spread model. Authored by maintainer lengau, the change passed linting and testing, updated the changelog, and was successfully integrated.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1386 fix: final spread test fixes for craft-application charmcraft merged Merged after approval by two reviewers. Resolves final spread test issues for craft-application across seven files, removing 127 lines and adding 104. Changes integrated into the main branch.
79%
#127 Fix spread tests imagecraft merged Merged after receiving approval from two reviewers and passing all CI checks. The changes fix spread tests across 11 files (+49/-38 lines).
74%
#1381 fix: fix most spread tests on craft-application charmcraft merged Merged updates fixing most spread tests for craft-application. Two smoketests remain broken. Approved despite minor linting and unit test failures. Resolves CRAFT-2239.
73%
#934 fix(templates): typo in spread .extension rockcraft merged Merged a single-line correction for a typo in the spread .extension template. The fix passed all CI checks and received approval from two reviewers before integration.
73%
#1325 test(spread): consolidate basic init/build tests charmcraft merged Merged after approval by two reviewers. Consolidates basic init and build spread tests across four files, reducing 80 lines and adding 28. Resolves CRAFT-2127.
72%
#2126 ci(docs): spread test documentation charmcraft merged Merged changes adding a CI workflow for spread testing documentation and adjusting tasks for Google runners. Approved by two reviewers, the update modifies five files (+100/-22 lines) and resolves CRAFT-3798.
72%
#5499 fix: evaluate variables in project file snapcraft merged Merged fix for project variables not evaluating in project files, caused by the craft-application 5 rebase. Includes a core22 spread test and changelog update. Resolves #5491.
71%
#299 refactor(spread): prototype spread extension fetch-service merged Merged after two approvals. Refactored test suites to use the spread extension mechanism, dynamically generating spread.yaml before execution. Resolves #291. Modified 14 files, +325/-317 lines.
71%
#2032 ci: fixes to several weekly spread tests charmcraft merged Merged CI fixes for several weekly spread tests. Approved by two reviewers and passed all checks with minimal changes across three files. Addresses initial test failures as a starting point for broader improvements.
70%
#4529 Spread update snapcraft merged Merged after approval by two reviewers and passing CI checks. The update modifies spread configuration across three files, adding 36 and removing 40 lines. Code coverage tests passed.
70%