← Back to issue list

fix: only run post prime in the process that ran the lifecycle

View original Github issue

Metadata

Project
craft-application
Number
#727
Type
pull request
State
merged
Author
upils
Labels
Created
Updated
Closed

Current evaluation

Merged a fix ensuring the post prime lifecycle step only runs in the initiating process, resolving #716 and CRAFT-4425. Approved by three reviewers with passing CI checks. A reviewer suggested adding a spread test later.

Suggested action:

No scores available.

Issue body

- [ ] Have you followed the guidelines for contributing? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `make lint && make test`? - [ ] Have you added an entry to the changelog (`docs/reference/changelog.rst`)? --- Fixes #716 CRAFT-4425

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged a fix ensuring the post prime lifecycle step only runs in the initiating process, resolving #716 and CRAFT-4425. Approved by three reviewers with passing CI checks. A reviewer suggested adding a spread test later.
qwen3.6-35b-a3b-mtp-q6 Fixed #716 and CRAFT-4425 by restricting the post-prime lifecycle step to the originating process. Merged after a reviewer suggested adding a spread test.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1073 fix: handle `--debug` for post-prime failures craft-application merged Merged fix resolving an exception when launching a debug shell after post-prime failures. Approved by three reviewers and passed CI checks. Resolves craft-application#1074 with 48 additions and 2 deletions across two files.
74%
#138 feat: post-prime hook for LifecycleService craft-application merged Merged feature adding a post-prime hook to LifecycleService. Approved by two reviewers, maintaining 99.18% test coverage. Changes span two files with a net addition of 55 lines.
71%