← Back to issue list

Refactor to return packaged resource names

View original Github issue

Metadata

Project
craft-application
Number
#741
Type
issue
State
open
Author
cmatsuoka
Labels
—
Created
Updated
Closed
—

Current evaluation

PackageService.pack still returns only artifact paths and exposes resource_map in the legacy path; newer artifact-aware packing bypasses it, so the requested API cleanup needs reassessment.

Suggested action: needs triage

Reason: The current source still defines pack() -> list[Path], a temporary resource_map property, and a lifecycle call that reads resource_map for legacy multi-package packing. However, #1111 added an artifact-aware pack_artifacts/get_artifacts flow with named artifact state, so maintainers must determine whether the proposed pack API change remains necessary or should be superseded; the issue also has no labels, comments, or explicit resolution.

Evaluated by: mr-cal-bot

Impact: 35 Quick Win: 10 Complexity: 52 Confidence: 88 Actionability: 60

Issue body

### What needs to get done The `pack` command in the package service currently returns a list of packaged artifacts, but In order to generate environment variables for resource files it should also return the resource names (or maybe fill a map passed as an optional argument). Refactor pack to obtain this information, and after that the `resource_map` property can be removed. ### Why it needs to get done The testing setup requires environment variables with resource names pointing to resource files.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha
Impact: 35
Quick Win: 10
Complexity: 52
Confidence: 88
Actionability: 60
needs triage PackageService.pack still returns only artifact paths and exposes resource_map in the legacy path; newer artifact-aware packing bypasses it, so the requested API cleanup needs reassessment.
qwen/qwen3.6-35b-a3b
Impact: 30
Quick Win: 17
Complexity: 30
Confidence: 70
Actionability: 80
needs triage Refactor pack method to return resource names alongside artifacts, enabling removal of resource_map property
qwen/qwen3.8-27b
Impact: 25
Quick Win: 11
Staleness: 75
Complexity: 55
Confidence: 65
Support Request: 0
keep open Maintainer-authored refactor task to make the package service's pack method return resource names so the temporary resource_map property can be removed. Still open, unlabelled, and inactive for ~15 months; the property remains in current code.
qwen/qwen3.6-35b-a3b
Staleness: 85
Complexity: 25
Confidence: 75
Support Request: 5
needs triage Refactor the pack command to return packaged resource names for environment variable generation, replacing the resource_map property. Currently untriaged and inactive for over a year.
qwen3.6-35b-a3b-mtp-q6
Staleness: 85
Complexity: 40
Confidence: 80
Support Request: 5
needs triage Refactor the pack command to return packaged resource names for environment variable generation, replacing the resource_map property. Currently unlabelled and unassessed after over a year of inactivity.

Update history

No update history recorded yet.

Related work

  • Related To: craft-application#739 (confidence 88%)

    The testing feature added artifact and resource-file variables and is the likely origin of the temporary resource_map design.

  • Related To: craft-application#1111 (confidence 82%)

    Conditional-repacking support introduced the newer named-artifact API and flow that avoids resource_map for opted-in applications.

Related issues

No related issues found above the similarity threshold.