← Back to issue list

Refactor to return packaged resource names

View original Github issue

Metadata

Project
craft-application
Number
#741
Type
issue
State
open
Author
cmatsuoka
Labels
—
Created
Updated
Closed
—

Current evaluation

Maintainer-authored refactor task to make the package service's pack method return resource names so the temporary resource_map property can be removed. Still open, unlabelled, and inactive for ~15 months; the property remains in current code.

Suggested action: keep open

Reason: The author (cmatsuoka) is a maintainer who filed this as a scoped internal task, and the target code is unchanged: craft_application/services/package.py still defines the resource_map property with a comment saying the two calls 'can be consolidated in the next API change', and lifecycle.py still reads self._services.package.resource_map. It is not stale-irrelevant (the workaround still exists), but it has no labels, assignee, or comments in 465 days, so it needs a maintainer to prioritise or explicitly defer it.

Impact: 25 Quick Win: 11.25 Staleness: 75 Complexity: 55 Confidence: 65 Support Request: 0

Issue body

### What needs to get done The `pack` command in the package service currently returns a list of packaged artifacts, but In order to generate environment variables for resource files it should also return the resource names (or maybe fill a map passed as an optional argument). Refactor pack to obtain this information, and after that the `resource_map` property can be removed. ### Why it needs to get done The testing setup requires environment variables with resource names pointing to resource files.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.8-27b
Impact: 25
Quick Win: 11.25
Staleness: 75
Complexity: 55
Confidence: 65
Support Request: 0
keep open Maintainer-authored refactor task to make the package service's pack method return resource names so the temporary resource_map property can be removed. Still open, unlabelled, and inactive for ~15 months; the property remains in current code.
qwen/qwen3.6-35b-a3b
Staleness: 85
Complexity: 25
Confidence: 75
Support Request: 5
needs triage Refactor the pack command to return packaged resource names for environment variable generation, replacing the resource_map property. Currently untriaged and inactive for over a year.
qwen3.6-35b-a3b-mtp-q6
Staleness: 85
Complexity: 40
Confidence: 80
Support Request: 5
needs triage Refactor the pack command to return packaged resource names for environment variable generation, replacing the resource_map property. Currently unlabelled and unassessed after over a year of inactivity.
qwen3.6-35b-a3b-mtp-q6
Staleness: 80
Complexity: 25
Confidence: 50
Support Request: 0
needs triage Refactor the pack command to return packaged resource names for environment variable generation. Open, unassigned, and inactive for over a month. Requires implementation to enable testing setup and remove the legacy resource_map property.

Update history

No update history recorded yet.

Related work

  • Caused By: craft-application#739 (confidence 70%)

    PR #739 'feat(testing): set artifact and resource file variables' introduced the resource_map property as a stopgap; this issue is the follow-up to fold that data into pack's return value and delete the property.

Related issues

No related issues found above the similarity threshold.