fix(PackageService): normalize paths returned by the pack method
Metadata
Current evaluation
Merged fix normalizing paths returned by PackageService.pack. The caller now handles path normalization and discards invalid results instead of relying on resolved filesystem paths. Approved by two reviewers with all CI checks passing.
Suggested action: —
No scores available.
Issue body
The `pack` method is implemented in the application's `PackageService`
and returns a list of packed files to the command runner. Instead of
relying on the application returning resolved filesystem paths, let the
caller normalize them and discard invalid results in the process.
Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
- [x] Have you followed the guidelines for contributing?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `make lint && make test`?
- [ ] Have you added an entry to the changelog (`docs/reference/changelog.rst`)?
---
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged fix normalizing paths returned by PackageService.pack. The caller now handles path normalization and discards invalid results instead of relying on resolved filesystem paths. Approved by two reviewers with all CI checks passing. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. The PackageService pack method no longer returns resolved filesystem paths. Instead, the caller now normalizes the returned paths and filters out invalid entries. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3534 repo: normalize only if there are packages to unpack | snapcraft | merged | Merged into master. Fixes a bug where pathlib.glob was incorrectly assumed to return a list instead of a generator. Ensures stage package normalization only runs when packages exist to unpack. Approved by two reviewers and passed CI. |