← Back to issue list

test: don't run staging tests if the API is erroring

View original Github issue

Metadata

Project
craft-application
Number
#778
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged #778 as commit 723c5d33, adding a preflight check that skips Launchpad staging tests when the API request fails or returns HTTP 5xx.

Resolution: closed resolved

Reason: PR #778 was approved and merged into main as commit 723c5d33. It prevents staging integration tests from running against an erroring Launchpad API.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint && make test`? - [ ] Have you added an entry to the changelog (`docs/reference/changelog.rst`)? ---

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged #778 as commit 723c5d33, adding a preflight check that skips Launchpad staging tests when the API request fails or returns HTTP 5xx.
stealth/space-bunny-alpha — closed resolved Merged PR #778 as commit 723c5d33, preventing staging tests from running when the API returns an error.
qwen/qwen3.6-35b-a3b — — Merged after approval from two reviewers. The change skips staging tests when the API errors, modifying two lines across one file. CI checks passed except one unrelated snap test, which did not block the merge.

Update history

No update history recorded yet.

Related work

  • Related To: craft-application#711 (confidence 85%)

    Earlier work skipped staging login tests when the endpoint was offline; #778 extended this behavior to API errors.

Related issues

Issue Project State Summary Similarity
#711 test(Launchpad): skip staging login if it's offline craft-application merged Merged PR #711 as commit b5d09612, adding an availability check that skips Launchpad's staging anonymous-login test when the staging API is offline.
76%
#602 tests: xfail launchpad test craft-application merged Merged in canonical/craft-application#602 (42a76dd5), xfailing the unavailable Launchpad staging endpoint test to unblock a craft-application release.
70%