refactor: delay creation of LifecycleManager
Metadata
Current evaluation
Merged into main after two approvals and passing CI. The change refactors LifecycleService to delay LifecycleManager initialization from __init__ to setup, optimizing performance. Diff coverage reached 100%.
Suggested action: —
No scores available.
Issue body
The previous version of the LifecycleService was initializing the craft-parts lifecycle manager during its __init__(). This is possibly an expensive operation that is better suited for the setup() method.
- [ ] Have you followed the guidelines for contributing?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `tox`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged into main after two approvals and passing CI. The change refactors LifecycleService to delay LifecycleManager initialization from __init__ to setup, optimizing performance. Diff coverage reached 100%. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into main. Refactored LifecycleService to delay LifecycleManager initialization from __init__ to setup, reducing overhead. Approved by maintainer tigarmo with 100% diff coverage. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #265 lifecycle_manager: minor primed packages sort refactoring | craft-parts | merged | Merged a minor refactoring to fix list sorting in lifecycle_manager after debug instrumentation was removed. Approved by one reviewer, passed CI checks, and applied with a +1/-3 line change. |