← Back to issue list

perf: add TC001/2/3 linter rules to check imports

View original Github issue

Metadata

Project
craft-application
Number
#797
Type
pull request
State
merged
Author
upils
Labels
Created
Updated
Closed

Current evaluation

Merged after approval. Introduces TC001/2/3 linter rules to validate imports and resolves associated errors across 29 files. Core CI checks passed. Implements gradual improvements to import handling precision.

Suggested action:

No scores available.

Issue body

- [ ] Have you followed the guidelines for contributing? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `make lint && make test`? - [ ] Have you added an entry to the changelog (`docs/reference/changelog.rst`)? --- Add TC001/2/3 linter rules to check imports and fixes errors found by these rules. No improvement to import time were specifically measured for this change but the goal is to gradually move to a more precise imports handling.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged after approval. Introduces TC001/2/3 linter rules to validate imports and resolves associated errors across 29 files. Core CI checks passed. Implements gradual improvements to import handling precision.
qwen3.6-35b-a3b-mtp-q6 Merged maintainer upils' changes adding TC001/2/3 linter rules to enforce precise import checking. The update resolves linting errors and establishes a foundation for improved import handling, with no immediate measurable performance gains.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#415 style: add TC001, TC002 and TC003 rules starbase merged Merged. Added TC001, TC002, and TC003 linting rules. Approved by two reviewers, passed all CI checks, and modified one file with three additions and three deletions.
73%
#1151 perf: Conditional imports for dependencies only used for type checks craft-parts merged Merged after approval by three reviewers and passing all CI checks. The PR adds linter rules for type-check-only imports and implements deferred imports to optimize runtime performance.
72%