← Back to issue list

5.7.0 causes app unit tests to fail because of duplicate callbacks.

View original Github issue

Metadata

Project
craft-application
Number
#873
Type
issue
State
closed
Author
lengau
Labels
Status: Triaged Type: Bug
Created
Updated
Closed

Current evaluation

Closed without a code fix after 5.7.0 exposed duplicate enable_overlay_eol callback registration; the last comment requested moving it under Application.run.

Resolution: closed stale

Reason: No resolving PR or commit was linked. The callback remains registered in LifecycleService.setup, and repository history shows no subsequent move or removal.

Evaluated by: mr-cal-bot

No scores available.

Issue body

### Bug Description Apps will have unit tests fail with `Callback Registration Error: callback function 'enable_overlay_eol' is already registered.` ### To Reproduce Check out Rockcraft at commit 4357d45db6964b93357d6da799912dcb99e4a75e and run the tests. ### part yaml ```shell ``` ### Relevant log output ```shell ===================================================================================== short test summary info ===================================================================================== FAILED tests/unit/services/test_lifecycle.py::test_lifecycle_package_repositories[project_keys0] - craft_parts.errors.CallbackRegistrationError: Callback registration error: callback function 'enable_overlay_eol' is already registered.. ============================================================== 1 failed, 435 passed, 1 skipped, 20 deselected, 20 warnings in 2.79s =============================================================== make: *** [common.mk:220: test-fast] Error 1 ```

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed stale Closed without a code fix after 5.7.0 exposed duplicate enable_overlay_eol callback registration; the last comment requested moving it under Application.run.
stealth/space-bunny-alpha — closed stale Closed without a fix for 5.7.0’s duplicate enable_overlay_eol callbacks; the last maintainer comment requested moving registration under Application.run.
stealth/space-bunny-alpha — closed stale Duplicate enable_overlay_eol callback registrations broke 5.7.0 unit tests. Tracked as CRAFT-4713, the report closed without a cited fix after a proposal to move registration under Application.run.
qwen/qwen3.6-35b-a3b — — Closed without resolution. Duplicate callback registration continues to break unit tests. A maintainer requested moving registration under Application.run to eliminate manual callback resets in integration tests.
qwen/qwen3.6-35b-a3b — — Closed. Reports duplicate callback registration causing unit test failures. A follow-up suggests refactoring callback handling under Application.run to avoid manual resets. No explicit fix or merge noted; likely abandoned or resolved internally.
qwen/qwen3.6-35b-a3b — — Closed after triage. A follow-up comment proposed refactoring callback registration under Application.run to prevent duplicate errors during test execution and simplify integration test fixtures.

Update history

No update history recorded yet.

Related issues

No related issues found above the similarity threshold.