← Back to issue list

feat: warn when running destructive commands without root

View original Github issue

Metadata

Project
craft-application
Number
#974
Type
pull request
State
merged
Author
bepri
Labels
—
Created
Updated
Closed

Current evaluation

Merged in craft-application PR #974 (commit 4b213f68), adding warnings when non-root users run lifecycle commands in --destructive-mode across all Craft tools.

Resolution: closed resolved

Reason: PR #974 merged with commit 4b213f68 after approval and all CI checks passed. Its warning implementation addresses canonical/snapcraft#5113.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint && make test`? - [x] Have you added an entry to the changelog (`docs/reference/changelog.rst`)? --- Raises a warning if a lifecycle command is run with `--destructive-mode` by a user other than root. Addresses https://github.com/canonical/snapcraft/issues/5113, but for all of the crafts :tada:. CRAFT-4948.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged in craft-application PR #974 (commit 4b213f68), adding warnings when non-root users run lifecycle commands in --destructive-mode across all Craft tools.
stealth/space-bunny-alpha — closed resolved Merged in craft-application PR #974 (4b213f68), adding warnings for non-root destructive lifecycle commands across all Craft tools and resolving snapcraft#5113.
qwen/qwen3.6-35b-a3b — — Merged following two reviewer approvals and successful CI checks. Introduces a warning for non-root users executing destructive lifecycle commands, resolving issue #5113 and CRAFT-4948. Changes span three files with 46 lines added.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/snapcraft#5113 (confidence 99%)

    The original request to warn non-root destructive-mode users was addressed upstream by this merged PR.

Related issues

Issue Project State Summary Similarity
#5113 warn if `snapcraft --destructive-mode` is run by non-root user snapcraft closed Enhancement request closed: snapcraft now warns when destructive-mode commands run as non-root, implemented upstream. Craft-application PR #974 (commit 4b213f68) merged and resolves this issue.
78%