← Back to issue list

chore: add fields and docstrings to package repository models

View original Github issue

Metadata

Project
craft-archives
Number
#162
Type
pull request
State
merged
Author
jahn-junior
Labels
Created
Updated
Closed

Current evaluation

Merged following approval by two reviewers. Added Pydantic fields and docstrings to package repository models. A failing CI test was acknowledged as pre-existing and unrelated to the changes.

Suggested action:

No scores available.

Issue body

- [X] Have you followed the guidelines for contributing? - [X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [X] Have you successfully run `make lint && make test`? --- I wasn't sure if we wanted to make these actual Pydantic fields or not. If not, I can revert the change and include all of the descriptions and example blocks in the docstrings themselves.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged following approval by two reviewers. Added Pydantic fields and docstrings to package repository models. A failing CI test was acknowledged as pre-existing and unrelated to the changes.
qwen3.6-35b-a3b-mtp-q6 Merged changes adding fields and docstrings to package repository models. The author used docstrings instead of Pydantic fields. Pre-existing unrelated test failures were acknowledged and did not prevent the merge.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#158 chore: update docstrings debcraft merged Merged updates to public function docstrings, adding missing parameters and return values. Approved by two reviewers, passed CI checks, and modified 10 files with 55 additions and 9 deletions.
80%
#778 chore: pydantic 2 related cleanup craft-parts merged Merged a Pydantic 2 compatibility cleanup. Approved by two reviewers and passed CI. Modified seven files with 28 additions and 26 deletions. Required PR #775.
79%
#33 chore!: update to Pydantic 2 craft-grammar merged Merged update to Pydantic 2. Resolves issue #32 by addressing breaking changes in grammar validation error messages. Approved by two reviewers, passed CI checks, and modified five files (+40/-41 lines).
78%
#621 chore: update fileset and organize docstrings craft-parts merged Merged a chore pull request updating the fileset and organizing docstrings. Changes affected two files (+22/-9 lines). Approved by two reviewers, passed CI checks, and was successfully merged by the maintainer.
78%
#207 chore(deps): drop Pydantic dependency craft-cli merged Merged changes remove the unused Pydantic dependency, resolving issue #201. Approved by two reviewers, passed CI checks, and reduced code by three lines across three files without impacting the 94.76% test coverage.
78%
#36 chore!: update to pydantic 2 craft-grammar merged Merged the Pydantic 2 migration across five files. Approved by two reviewers and passed CI. The maintainer manually verified the author's Canonical employment to override an automated CLA check failure before finalizing the merge.
77%
#794 chore: remove pydantic warnings craft-parts merged Successfully merged after approval by two reviewers and passing CI checks. The changes remove pydantic warnings across 9 files, adding 30 lines and deleting 16 to clean up framework deprecation notices.
76%
#4375 chore(deps): add pygit to doc requirements snapcraft merged Merged to add pygit to documentation requirements, fixing a Sphinx build failure from a missing pygit2 module. Approved by two reviewers and passed CI checks.
76%
#122 chore: eliminate pydantic warnings craft-archives merged Merged after two approvals and passing CI. Refactored three files to eliminate pydantic deprecation warnings, adding 24 lines and removing 15.
75%
#4351 chore(docs): bump requirements and build environment snapcraft merged Merged after reviewer approval and passing CI. Updated the build environment to Ubuntu 22.04 and Python 3.10, bumped documentation requirements, and removed boilerplate comments. The commit adds 13 lines and removes 24 across two files.
74%