← Back to issue list

chore: add fields and docstrings to package repository models

View original Github issue

Metadata

Project
craft-archives
Number
#162
Type
pull request
State
merged
Author
jahn-junior
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #162 as commit 4c16960, adding fields and docstrings to package repository models; minimum-dependency test failures were noted as unrelated.

Resolution: closed resolved

Reason: PR #162 was approved and merged as commit 4c16960. The maintainer noted that the minimum-dependency test failures predated and were unrelated to the change.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [X] Have you followed the guidelines for contributing? - [X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [X] Have you successfully run `make lint && make test`? --- I wasn't sure if we wanted to make these actual Pydantic fields or not. If not, I can revert the change and include all of the descriptions and example blocks in the docstrings themselves.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #162 as commit 4c16960, adding fields and docstrings to package repository models; minimum-dependency test failures were noted as unrelated.
stealth/space-bunny-alpha — closed resolved Merged into craft-archives with Pydantic fields and docstrings added to package repository models. Two reviewers approved; the lone CI failure was deemed pre-existing and unrelated.
qwen/qwen3.6-35b-a3b — — Merged following approval by two reviewers. Added Pydantic fields and docstrings to package repository models. A failing CI test was acknowledged as pre-existing and unrelated to the changes.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#621 chore: update fileset and organize docstrings craft-parts merged PR #621 was merged as commit c15e8dff, updating fileset documentation and reorganizing docstrings across two files (+22/-9).
78%
#158 chore: update docstrings debcraft merged PR #158 by cmatsuosa merged as commit cbca713, adding missing parameter and return value entries to public function docstrings across 10 files (+55/-9). Follow-up commit 0d328c4 relaxed docstring rules for overrides.
77%
#364 chore(deps): update dependencies rockcraft merged Merged dependency updates in PR #364 via commit 1661d115, changing seven files (+152/-174) after approval by two reviewers.
75%
#340 chore(deps): update documentation dependencies rockcraft closed Closed unmerged after 3+ years; newer documentation dependencies were later merged in PR #538 (commit b007f265).
73%
#556 chore(deps): update readthedocs environment craft-parts merged Merged PR #556 in commit 813733f7, updating the Read the Docs build environment after two approvals and with no unresolved review comments.
73%
#734 chore(deps): update documentation dependencies craft-parts closed Renovate PR #734 was closed unmerged after five days of inactivity; its dependency versions appeared in 84e96162 and were later carried forward by 67623b5d.
72%
#773 chore: documentation polish craft-parts merged PR #773 merged documentation-only polishing: 32 additions and 11 deletions across two files, after approval by two reviewers.
72%
#4483 chore(deps): update documentation dependencies snapcraft closed Renovate docs-dependency PR closed unmerged with no reviews or CI; the same updates landed later via snapcore/snapcraft#4728 (commit 477918081).
71%
#536 chore(deps): update bugfixes rockcraft merged Renovate bugfix PR merged as commit b33a48c9, bumping 11 dev/test dependencies (cachetools, coverage, cryptography, filelock, keyring, nh3, pyparsing, rich, tomlkit, virtualenv, wcmatch) across 3 files (+14/-14), with 2 approvals.
71%
#368 chore(deps): update documentation dependencies craft-providers merged Renovate dependency bump PR merged as commit 5eae8d4 (2023-07-28): docs/sphinx-lint 0.6.7→0.6.8 and docs/sphinx-toolbox 3.4.0→3.5.0, +2/-2 lines in the docs requirements.
71%