← Back to issue list

fix: handle installer tests on non-LTS Ubuntu and Debian releases

View original Github issue

Metadata

Project
craft-archives
Number
#222
Type
pull request
State
open
Author
Copilot
Labels
—
Created
Updated
Closed
—

Current evaluation

Small +4/-3 fix to installer tests: replaces direct dict access with .get() and adds distro.id() check to avoid KeyError on non-LTS Ubuntu/Debian. All CI passing, pending review (0 reviewers). Last activity 48 days ago.

Suggested action: needs review

Reason: All 10 CI checks pass and the diff is a trivial 4-line test fix, but it has sat with 0 reviewers for ~5 months. Merged PR #115 (canonical/craft-archives#115) already made cloud archive tests optional by distro, so a maintainer should confirm whether this smaller .get() fix is still needed or redundant before merging.

Impact: 30 Quick Win: 27.0 Staleness: 40 Complexity: 10 Confidence: 65

Issue body

- [x] Fix `KeyError` for non-LTS Ubuntu by using `.get()` and `distro.id()` check - [x] Fix ruff formatting: collapse `CLOUD_DATA` ternary to a single line - [x] All 218 unit tests pass - [x] `test_installer.py` collects without errors <!-- START COPILOT CODING AGENT TIPS --> --- 💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more [Copilot coding agent tips](https://gh.io/copilot-coding-agent-tips) in the docs.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.8-27b
Impact: 30
Quick Win: 27.0
Staleness: 40
Complexity: 10
Confidence: 65
needs review Small +4/-3 fix to installer tests: replaces direct dict access with .get() and adds distro.id() check to avoid KeyError on non-LTS Ubuntu/Debian. All CI passing, pending review (0 reviewers). Last activity 48 days ago.
qwen/qwen3.6-35b-a3b
Staleness: 20
Complexity: 10
Confidence: 85
needs review Fixes KeyError in installer tests for non-LTS Ubuntu/Debian and resolves ruff formatting issues. All CI checks pass, but review is pending with no maintainer feedback yet.
qwen3.6-35b-a3b-mtp-q6
Staleness: 80
Complexity: 15
Confidence: 85
needs review Fixes KeyError in installer tests for non-LTS Ubuntu/Debian and resolves ruff formatting. All 218 unit tests pass. Inactive for 103 days awaiting maintainer review.
qwen3.6-35b-a3b-mtp-q6
Staleness: 60
Complexity: 15
Confidence: 80
needs review Fixes a KeyError in installer tests for non-LTS Ubuntu and Debian releases, and resolves ruff linting failures. All unit tests pass. The branch is ready but has been open for 81 days without review and needs triage.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/craft-archives#102 (confidence 85%)

    Issue 'Installer tests fail on non-LTS Ubuntu versions' describes the exact KeyError this PR fixes; still open.

  • Related To: canonical/craft-archives#115 (confidence 70%)

    Merged PR that made cloud archive tests optional by distro (+37/-22); may partially overlap with this PR's .get() fix, making this PR potentially redundant.

Related issues

No related issues found above the similarity threshold.