← Back to issue list

test: mark is_on_old_releases tests as slow

View original Github issue

Metadata

Project
craft-archives
Number
#269
Type
pull request
State
merged
Author
LoweRAM
Labels
—
Created
Updated
Closed

Current evaluation

Marked test_is_on_old_releases_real_ubuntu and test_is_on_old_releases_custom with @pytest.mark.slow in merged PR #269 to prevent network timeouts from blocking fast test runs.

Resolution: closed resolved

Reason: PR #269 was merged, adding @pytest.mark.slow to two tests that make real HTTP requests, preventing them from hanging fast test runs.

Evaluated by: mr-cal-bot

No scores available.

Issue body

## Summary `test_is_on_old_releases_real_ubuntu` and `test_is_on_old_releases_custom` perform real HTTP requests to archive servers (such as `old-releases.ubuntu.com` and Debian archive mirrors). When network connectivity is degraded or remote endpoints time out, these tests hang for several minutes and cause fast test runs (`make test-fast`) to fail or time out. Marking them with `@pytest.mark.slow` ensures they run as part of the slow test suite (`make test-slow` / slow matrix jobs) and do not block fast test execution. ## Changes - `tests/integration/test_defaults.py`: mark `test_is_on_old_releases_real_ubuntu` and `test_is_on_old_releases_custom` with `@pytest.mark.slow`. ## Validation - `make test-fast` passes in ~4s (previously hung for >5m when endpoints timed out) - `uv run pytest -m slow tests/integration/test_defaults.py` still discovers and runs the tests - `make format` and `make lint-code` pass cleanly

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b — closed resolved Marked test_is_on_old_releases_real_ubuntu and test_is_on_old_releases_custom with @pytest.mark.slow in merged PR #269 to prevent network timeouts from blocking fast test runs.
qwen/qwen3.6-35b-a3b
Impact: 25
Quick Win: 20
Complexity: 5
Confidence: 90
Actionability: 85
needs review Marks two HTTP-dependent tests as slow to prevent CI hangs, improving test-fast reliability. Approved by 2 reviewers, CI passing.
qwen/qwen3.6-35b-a3b
Impact: 35
Quick Win: 19
Complexity: 10
Confidence: 75
Actionability: 60
needs review Marks two HTTP-dependent tests with @pytest.mark.slow to prevent CI hangs during fast test runs. Approved by 2 reviewers; fast tests pass but slow tests fail due to network timeouts.

Update history

Date Change
merged
updated
updated
updated
updated
created

Related issues

Issue Project State Summary Similarity
#270 test: mark use_old_releases integration test as slow craft-archives merged Merged PR #270, which marks test_use_old_releases as slow to exclude it from fast test runs, following up on #269.
83%
#658 test(remote-build): mark slow remote-build unit tests as slow craft-application merged Merged PR #658 (commit 2b31b06e) added two @pytest.mark.slow annotations to slow remote-build unit tests, letting them be deselected in the default fast test run.
71%