repo: replace "apt-key" with "gpg" to handle keys
Metadata
Current evaluation
Merged update replacing the deprecated apt-key command with gpg for repository key management. Adds integration tests, removes an obsolete mock, and resolves CRAFT-1626. Approved by reviewers, passed CI checks, and increased test coverage by 0.03%.
Suggested action: —
No scores available.
Issue body
The first commit adds some integration tests with some code that ends up getting removed in the second commit (a mock that is no longer needed). Reviewing per-commit shows the "story" but reviewing just the final result should be straighforward too.
CRAFT-1626
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged update replacing the deprecated apt-key command with gpg for repository key management. Adds integration tests, removes an obsolete mock, and resolves CRAFT-1626. Approved by reviewers, passed CI checks, and increased test coverage by 0.03%. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into main. Replaced deprecated apt-key with gpg for repository key management, resolving CRAFT-1626. Updated integration tests and removed an obsolete mock. Code coverage increased by 0.03%. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #4021 [WIP] replace "apt-key" with "gpg" calls | snapcraft | closed | Closed as abandoned, the WIP branch replacing apt-key with gpg calls received zero reviews, comments, or CI checks over 1275 days and was never merged. | |
| #3647 repo: add package repository handling (CRAFT-846) | snapcraft | merged | Merged into main. Introduces apt repository and PPA handling definitions and helpers, consolidated from multiple prior pull requests. Approved by reviewers, passed all CI checks, and increased test coverage. | |
| #46 repo: don't use gpg --show-keys | craft-archives | merged | Merged. Replaced the Ubuntu 20.04-only gpg --show-keys command with a compatible alternative to support Ubuntu 18.04. Updated CI to run integration tests on 18.04. Approved, passed checks, and achieved 100% diff coverage. | |
| #5412 test: update multi-key test for package repositories | snapcraft | merged | Merged test updates adding a new valid GPG key to replace an expired apt.puppet.com key, resolving failing multi-key repository tests. The change passed review and CI. Reviewers recommended migrating to a team-controlled PPA to prevent future expiration issues. | |
| #3359 repo: key management refactor | snapcraft | merged | Merged a key management refactor that decouples logic into a new AptKeyManager class. Enforces 40-character key IDs, updates schema validation, and adjusts asset search paths. Approved, passed CI, and increased test coverage by 0.10%. | |
| #189 fix: retry key receiving on port TCP/80 if using default keyserver | craft-archives | merged | Merged fix that retries GPG key retrieval on TCP/80 when default port 11371 times out, and optimizes AptGPGKeyInstallError after the apt-key to gpg migration. Approved by three reviewers, passed all CI checks, and resolves #165 and CRAFT-4560. |