← Back to issue list

repo: create the keyrings dir if necessary

View original Github issue

Metadata

Project
craft-archives
Number
#47
Type
pull request
State
merged
Author
tigarmo
Labels
Created
Updated
Closed

Current evaluation

Merged into main. Adds logic to create /etc/apt/keyrings if missing, resolving Ubuntu 18.04 compatibility issues. Approved by reviewer, passed CI checks, and increased test coverage by 0.15%.

Suggested action:

No scores available.

Issue body

/etc/apt/keyrings is only created by Apt after a certain version; for ubuntu 18.04, the directory is not there by default, so check and create it if necessary. - [ ] Have you followed the guidelines for contributing? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `tox`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged into main. Adds logic to create /etc/apt/keyrings if missing, resolving Ubuntu 18.04 compatibility issues. Approved by reviewer, passed CI checks, and increased test coverage by 0.15%.
qwen3.6-35b-a3b-mtp-q6 Merged into main. Introduces a check to create /etc/apt/keyrings if absent, ensuring compatibility with Ubuntu 18.04. The commit achieved 100% diff coverage and increased overall repository coverage by 0.15%.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1046 fix: add keyrings to standard chroot mount craft-parts merged Merged after reviewer approval and passing CI. Adds the keyrings directory to standard chroot mounts to enable archive signature verification during apt-upgrade in noble build-bases. Squash-merged to bypass unrelated CI failures.
75%
#32 keys: per-repository keyrings craft-archives merged Merged per-repository keyrings implementation (CRAFT-1627). Approved by two reviewers, passed CI, and changed nine files with a 2.14% coverage increase. Lint and test refinements were deferred to follow-up PRs.
71%