← Back to issue list

keys: handle keyring path parents not existing

View original Github issue

Metadata

Project
craft-archives
Number
#50
Type
pull request
State
merged
Author
lengau
Labels
Created
Updated
Closed

Current evaluation

Merged changes to handle non-existent keyring path parents. Approved by two reviewers, modified three files (+19/-4), and achieved 100% diff coverage. Required for rockcraft PR #217.

Suggested action:

No scores available.

Issue body

- [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `tox`? ----- This is needed for https://github.com/canonical/rockcraft/pull/217

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged changes to handle non-existent keyring path parents. Approved by two reviewers, modified three files (+19/-4), and achieved 100% diff coverage. Required for rockcraft PR #217.
qwen3.6-35b-a3b-mtp-q6 Merged into main. Adds logic to automatically create missing keyring path parent directories, preventing initialization errors. Achieved 100% test coverage and successfully integrated to support upstream rockcraft.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#32 keys: per-repository keyrings craft-archives merged Merged per-repository keyrings implementation (CRAFT-1627). Approved by two reviewers, passed CI, and changed nine files with a 2.14% coverage increase. Lint and test refinements were deferred to follow-up PRs.
75%
#170 fix: catch keyring locked error craft-store merged Merged to resolve issue #166 by catching the keyring locked error. Approved by two reviewers with a two-line change in one file.
72%
#206 fix: make compatible with keyring 25 craft-store merged Merged to resolve issue #162 by updating code for keyring 25 compatibility. Approved by three reviewers, the change modifies two files with minimal adjustments (+3/-2 lines) and was successfully integrated.
71%
#163 fix: workaround for keyring 25 incompatibility craft-store merged Merged a one-line workaround to resolve keyring 25 incompatibility. Approved by two reviewers and passed CI checks, addressing issue #162.
70%