Add a fuller integration test, and multiple minor changes to support it
Metadata
Current evaluation
Merged. Added a comprehensive integration test for repo.install() with minor supporting changes across seven files. Approved, passed CI, and achieved 100% diff coverage. Resolves CRAFT-1649 and CRAFT-1682.
Suggested action: —
No scores available.
Issue body
This PR's main purpose is to add an integration test that exercises `repo.install()` covering the repository types that we currently support. In order to do this, I had to make multiple minor changes. The updates are applied over a handful of self-confined commits, which I hope will make the review easier. At merge time we can keep them as-is or squash 'em all, I don't have a strong preference either way.
CRAFT-1649
CRAFT-1682
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged. Added a comprehensive integration test for repo.install() with minor supporting changes across seven files. Approved, passed CI, and achieved 100% diff coverage. Resolves CRAFT-1649 and CRAFT-1682. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into main, adding a comprehensive integration test for repo.install() covering all supported repository types alongside minor supporting changes. The merge increased overall code coverage by 0.06% with 100% diff coverage, resolving CRAFT-1649 and CRAFT-1682. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #46 Update dependencies and adapt to craft-archives | imagecraft | merged | Merged after passing CI and approval. Updates dependencies and adapts code to craft-archives changes, resolving FR-8231. Maintains 97.60% test coverage. Documentation build warnings were noted but did not block integration. | |
| #129 Added an integration test to verify that subprocess output is captured without noticeable delays (CRAFT-1366). | craft-cli | merged | Merged an integration test verifying subprocess output capture without noticeable delays (CRAFT-1366). Approved by one reviewer with no unresolved comments. Added 69 lines to one file and successfully integrated. | |
| #217 repo: add support for package repositories | rockcraft | merged | Added support for package repositories. Merged after approval by two reviewers and passing CI checks. Modified 16 files (+346/-31), resolving CRAFT-1553 and enabling downstream testing. | |
| #82 test: improve integration testing | craft-store | merged | Merged improvements to integration testing across eight files. The update works around external fork credential limitations by running full tests only after merging to main. Approved by one reviewer and passed CI. | |
| #77 tests: add integration tests for application plugins (CRAFT-69) | craft-parts | merged | Merged integration tests for application plugins. Approved by two reviewers, passed CI checks, and added 203 lines across two files to verify plugin registration and functionality. | |
| #3647 repo: add package repository handling (CRAFT-846) | snapcraft | merged | Merged into main. Introduces apt repository and PPA handling definitions and helpers, consolidated from multiple prior pull requests. Approved by reviewers, passed all CI checks, and increased test coverage. | |
| #717 fix(test): minor test fixes | craft-application | merged | Merged minor test fixes replacing spread test pausing with a stream approach and adopting the new reroot key. Resolves issues #704 and #715, plus CRAFT-4399 and CRAFT-4411. Approved by two reviewers with all CI checks passing. | |
| #73 tests: add stage snaps integration test (CRAFT-68) | craft-parts | merged | Merged an integration test verifying stage-snaps are correctly unpacked into the part install directory. Approved by two reviewers, passed CI, and added 133 lines across two files. | |
| #349 test: add overlay plugin integration test | imagecraft | merged | Merged following successful CI checks and dual reviewer approval. The update adds integration tests for overlay plugin commands and bumps the craft-parts dependency across eight files. | |
| #3636 parts: integrate craft-parts (CRAFT-765) | snapcraft | merged | Merged after reviewer approval and passing CI checks. Integrates craft-parts for part validation and lifecycle processing. Modifies 12 files, adding 369 lines and removing 20, fulfilling CRAFT-765. |