← Back to issue list

Add a fuller integration test, and multiple minor changes to support it

View original Github issue

Metadata

Project
craft-archives
Number
#56
Type
pull request
State
merged
Author
tigarmo
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #56 added fuller repo.install() integration coverage for supported repository types, plus minor supporting changes.

Resolution: closed resolved

Reason: PR #56 was approved and merged into main. It added end-to-end integration testing for repo.install() and the supporting changes required across repository implementations.

Evaluated by: mr-cal-bot

No scores available.

Issue body

This PR's main purpose is to add an integration test that exercises `repo.install()` covering the repository types that we currently support. In order to do this, I had to make multiple minor changes. The updates are applied over a handful of self-confined commits, which I hope will make the review easier. At merge time we can keep them as-is or squash 'em all, I don't have a strong preference either way. CRAFT-1649 CRAFT-1682

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #56 added fuller repo.install() integration coverage for supported repository types, plus minor supporting changes.
stealth/space-bunny-alpha — closed resolved Merged PR #56 at 1a7d636, adding comprehensive repo.install() integration coverage for supported repository types and supporting changes.
qwen/qwen3.6-35b-a3b — — Merged. Added a comprehensive integration test for repo.install() with minor supporting changes across seven files. Approved, passed CI, and achieved 100% diff coverage. Resolves CRAFT-1649 and CRAFT-1682.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#38 tests: add package repository tests craft-archives merged Merged PR #38 as commit e49a3d9, adding package-repository tests ahead of pinning changes; Codecov reported a 1.41% coverage increase.
72%