← Back to issue list

util: replace os_release.py with distro package

View original Github issue

Metadata

Project
craft-archives
Number
#59
Type
pull request
State
merged
Author
lengau
Labels
Created
Updated
Closed

Current evaluation

Merged: replaced os_release.py with the distro package. Approved by a reviewer, passed CI, and reduced code by 90 lines across five files. Validated in snapcraft and rockcraft, increasing coverage by 0.01%.

Suggested action:

No scores available.

Issue body

- [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `tox`? ----- Tested with snapcraft: https://github.com/snapcore/snapcraft/pull/4155 Tested with rockcraft: https://github.com/canonical/rockcraft/pull/268

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged: replaced os_release.py with the distro package. Approved by a reviewer, passed CI, and reduced code by 90 lines across five files. Validated in snapcraft and rockcraft, increasing coverage by 0.01%.
qwen3.6-35b-a3b-mtp-q6 Merged into main, replacing the custom os_release.py module with the standard distro package. Validated across snapcraft and rockcraft. Code coverage increased by 0.01% with 100% diff coverage.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1527 repo: Use os-release(5) to detect supported Linux distributions snapcraft merged Merged after replacing the deprecated platform.linux_distribution method with /etc/os-release for Linux detection. Refactored into snapcraft/internal/common.py per reviewer feedback, approved by three reviewers, passed CI, and modified 10 files.
76%
#356 utils: remove Ubuntu-specific code from OsRelease craft-parts merged Merged to remove Ubuntu-specific code from the OsRelease utility, resolving CRAFT-1584. Approved by reviewer, passed CI, and deleted 62 lines across two files after addressing linting rules in related PRs.
70%