← Back to issue list

util: replace os_release.py with distro package

View original Github issue

Metadata

Project
craft-archives
Number
#59
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #59 by lengau replaced craft-archives' hand-rolled os_release.py with the upstream distro package, adding distro>=1.3.0 to pyproject.toml. Merged as commit 0d2ba14 (5 files, +15/-105); verified downstream in snapcraft#4155 and rockcraft#268.

Resolution: closed resolved

Reason: The PR was approved and merged into main as commit 0d2ba14 ('util: replace os_release.py with ditsro package (#59)'). The os_release.py module no longer exists in the tree, and craft_archives/repo/apt_sources_manager.py now imports distro with 'distro>=1.3.0' declared in pyproject.toml, confirming the refactor landed.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `tox`? ----- Tested with snapcraft: https://github.com/snapcore/snapcraft/pull/4155 Tested with rockcraft: https://github.com/canonical/rockcraft/pull/268

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #59 by lengau replaced craft-archives' hand-rolled os_release.py with the upstream distro package, adding distro>=1.3.0 to pyproject.toml. Merged as commit 0d2ba14 (5 files, +15/-105); verified downstream in snapcraft#4155 and rockcraft#268.
stealth/space-bunny-alpha — closed resolved Merged #59, replacing the custom os_release.py implementation with the distro package; commit 0d2ba14.
qwen/qwen3.6-35b-a3b — — Merged: replaced os_release.py with the distro package. Approved by a reviewer, passed CI, and reduced code by 90 lines across five files. Validated in snapcraft and rockcraft, increasing coverage by 0.01%.

Update history

No update history recorded yet.

Related work

  • Related To: snapcore/snapcraft#4155 (confidence 70%)

    Downstream testing PR cited in the description for the distro replacement

  • Related To: canonical/rockcraft#268 (confidence 70%)

    Downstream testing PR cited in the description for the distro replacement

Related issues

Issue Project State Summary Similarity
#1333 Consolidate `os-release` utils with other repositories craft-parts open Replace Craft Parts' hand-rolled os-release parser with the distro library; maintainers agreed on this direction, but no implementation has landed and the work remains open.
71%