← Back to issue list

repo: fix bad typing_extensions interaction

View original Github issue

Metadata

Project
craft-archives
Number
#78
Type
pull request
State
merged
Author
tigarmo
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #78 as commit 7407d1d, fixing the typing_extensions interaction in code rather than permanently pinning the dependency to 4.5.0.

Resolution: closed resolved

Reason: PR #78 was merged into main as commit 7407d1d. It implemented a targeted code fix instead of retaining a typing_extensions 4.5.0 pin.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Ref: https://github.com/pydantic/pydantic/issues/5821#issuecomment-1559196859 We could also pin typing_extensions to 4.5.0 instead, but those pins have a tendency of sticking around. - [ ] Have you followed the guidelines for contributing? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `tox`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #78 as commit 7407d1d, fixing the typing_extensions interaction in code rather than permanently pinning the dependency to 4.5.0.
stealth/space-bunny-alpha — closed resolved PR #78 by tigarmo merged as commit 7407d1d; fixed a bad typing_extensions interaction in repo code instead of pinning the dependency to 4.5.0.
stealth/space-bunny-alpha — closed resolved Merged PR #78 as commit 7407d1d, fixing a typing_extensions interaction in code rather than permanently pinning the dependency to 4.5.0.
qwen/qwen3.6-35b-a3b — — Merged a fix for a bad typing_extensions interaction. The change updates code handling instead of pinning the dependency version. Approved by a reviewer, passed CI, and merged into main with a +7/-1 line change.

Update history

No update history recorded yet.

Related work

  • Related To: pydantic#5821 (confidence 90%)

    The upstream typing_extensions interaction report was cited as the motivation.

Related issues

Issue Project State Summary Similarity
#1168 chore(deps): update dependency typing_extensions to v4.7.1 - autoclosed charmcraft closed Renovate autoclosed unmerged PR #1168; its typing_extensions 4.7.1 update was abandoned. Later PR #1276 merged as 436a0f3b, advancing the dependency to 4.8.0.
71%
#451 chore(deps): update dependency typing_extensions to v4.9.0 - autoclosed rockcraft closed Renovate PR #451 was autoclosed without merging, abandoning the proposed typing_extensions 4.8.0-to-4.9.0 update.
70%