← Back to issue list

keys: list fingerprints exactly as python-gnupg does it

View original Github issue

Metadata

Project
craft-archives
Number
#84
Type
pull request
State
merged
Author
tigarmo
Labels
—
Created
Updated
Closed

Current evaluation

PR #84 merged as commit b1c20e2 into hotfix/1.1.1 (maintainer tigarmo). Rewrote AptKeyManager.get_key_fingerprints() to parse gpg --import show-only output, skipping sub-key fpr lines and listing primary-key fingerprints in gpg order including expired keys, matching python-gnupg.

Resolution: closed resolved

Reason: The PR itself was merged (approved, commit b1c20e2 "keys: list fingerprints exactly as python-gnupg does it (#84)"), and the resulting logic is present in craft_archives/repo/apt_key_manager.py: only pub: fpr: lines are collected. Follow-up PRs #86 and #87 continued the 1.1.x multi-key fix series.

Evaluated by: mr-cal-bot

No scores available.

Issue body

This commit updates the logic of `get_key_fingerprints()` to be the same as python-gnupg's (used before 1.0): - Don't list the fingerprints of sub-keys; - List the fingerprints of primary keys in the order that they are listed by gpg, even if the key is expired. The commit is the first one on the road to fixing a regression in the 1.* release series, of repository keys with more than one key (primary or sub-key) not being supported. - [ ] Have you followed the guidelines for contributing? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `tox`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved PR #84 merged as commit b1c20e2 into hotfix/1.1.1 (maintainer tigarmo). Rewrote AptKeyManager.get_key_fingerprints() to parse gpg --import show-only output, skipping sub-key fpr lines and listing primary-key fingerprints in gpg order including expired keys, matching python-gnupg.
stealth/space-bunny-alpha — closed resolved Merged #84 (ca6b641) to match python-gnupg: exclude sub-key fingerprints and preserve GPG’s primary-key order, including expired keys.
qwen/qwen3.6-35b-a3b — — Merged updates to get_key_fingerprints() to match python-gnupg behavior, excluding sub-keys and preserving primary key order. Resolves a regression in the 1.* series regarding multi-key repository support. Approved, passed CI, and increased coverage.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/craft-archives#86 (confidence 85%)

    Follow-up hotfix 'keys: make AptKeyManager.install_key() more robust' (commit 9a9706b), continuing the same 1.1.x multi-key regression fix.

  • Related To: canonical/craft-archives#87 (confidence 80%)

    Follow-up commit 9fbb5ce 'keys: forward the key-id to install_key()', building on the fingerprint logic changed here.

Related issues

No related issues found above the similarity threshold.