keys: make AptKeyManager.install_key() more robust
Metadata
Current evaluation
Closed unmerged; the intended AptKeyManager.install_key() robustness work landed in craft-archives#86 via commit 9a9706b.
Resolution: closed superseded
Reason: PR #85 was closed without merging, while the same robustness changes were submitted separately in #86. PR #86 merged as commit 9a9706b, adding multi-key handling, GPG diagnostics, and target-fingerprint verification.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [ ] Have you followed the guidelines for contributing?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `tox`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed superseded | Closed unmerged; the intended AptKeyManager.install_key() robustness work landed in craft-archives#86 via commit 9a9706b. | |
| stealth/space-bunny-alpha | — | closed superseded | Closed unmerged; equivalent AptKeyManager.install_key() robustness work landed in canonical/craft-archives#86 via commit 9a9706b. | |
| stealth/space-bunny-alpha | — | closed superseded | Closed unmerged; the same AptKeyManager.install_key() robustness work landed in canonical/craft-archives#86 via commit 9a9706b, adding multi-key handling, GPG diagnostics and target fingerprints. | |
| qwen/qwen3.6-35b-a3b | — | — | Modifications to make AptKeyManager.install_key() more robust were closed without merging. Lacking reviewer feedback, CI validation, and follow-up activity, the changes were abandoned. |
Update history
No update history recorded yet.
Related work
-
Superseded By:
craft-archives#86
(confidence 100%)
The equivalent implementation landed in PR #86 and was merged as commit 9a9706b.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #86 keys: make AptKeyManager.install_key() more robust | craft-archives | merged | Merged as 9a9706b: AptKeyManager.install_key() now accepts multi-key input, tolerates GPG diagnostics, and can verify a target fingerprint. | |
| #83 AptKeyManager.install_key() is unnecessarily restrictive | craft-archives | closed | Fixed by merged PR canonical/craft-archives#86 (commit 9a9706b), making AptKeyManager.install_key() handle keys with primary and subkey fingerprints. | |
| #3359 repo: key management refactor | snapcraft | merged | Merged #3359 in commit 8272e54e3, decoupling key handling into AptKeyManager, enforcing 40-character key IDs, and tightening key-asset validation and tests. |