Better tested help parsing function, with a bug fixed.
Metadata
Current evaluation
Merged after approval. Improved testing for the help parsing function and fixed a bug where errors were not properly raised when using the --all flag with extra arguments. Changes span two files with 100 additions and 12 deletions.
Suggested action: —
No scores available.
Issue body
In preparaion to the "help with markdown output" work I better tested the help parsing function, and fixed a bug where the error was not properly raises when `--all` was used with some extra info.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged after approval. Improved testing for the help parsing function and fixed a bug where errors were not properly raised when using the --all flag with extra arguments. Changes span two files with 100 additions and 12 deletions. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged enhancements to the help parsing function, adding comprehensive testing and fixing a bug where errors were not raised when --all was used with extra arguments. Prepares the codebase for markdown output support. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1686 fix(test): parse test command arguments | charmcraft | merged | Merged a fix updating the test command to parse arguments directly instead of forwarding them raw to spread. This enables consistent double-dashed long options and improved help messages. Approved by two reviewers, modifying five files with 55 additions and 32 deletions. | |
| #211 Exercise command parsers. | charmcraft | merged | Merged fix for a bug where the help command always returned an error. Updates help logic to only error on actual failures and adds tests exercising all command parsers, resolving issue #210. Approved by two reviewers and passed CI. | |
| #207 Avoid a duplicated -h/--help option when getting help for a command. | charmcraft | merged | Merged a fix to eliminate duplicate -h/--help options in command help output by disabling ArgumentParser's automatic help flag addition. Existing tests were updated to expose duplicates. Approved by two reviewers and passed CI. |