← Back to issue list

When the Printer stops it needs to clean the last line if it was transient progress

View original Github issue

Metadata

Project
craft-cli
Number
#125
Type
issue
State
open
Author
facundobatista
Labels
—
Created
Updated
Closed
—

Current evaluation

Reporter (maintainer facundobatista) asked the Printer to clear the transient progress line when stopping or pausing. Implemented in PR #126 (commit 9f9df27, merged as 2cbced2); issue left open.

Suggested action: close resolved

Reason: Commit 9f9df27 "printer: enhance ephemeral message handover after pause() or stop()" merged via PR #126 (merge commit 2cbced2, branch flotter/enhance-transient-emit-pause) implements exactly this request: the branch name and commit title cover both scenarios in the body (stop and emit.pause()), and the issue summary independently records resolution by PR #126. Confidence is 90 rather than higher only because the file-read/grep tools failed with "No pinned SHA available for project 'craft-cli'", so I confirmed the fix from commit history and the issue record rather than by re-reading the current Printer implementation.

Evaluated by: mr-cal-bot

Impact: 30 Quick Win: 18 Complexity: 30 Confidence: 90 Actionability: 85

Issue body

This will show both when stopping everything and when calling pause. For example, check the two following codes: ``` emit.progress("Long text") time.sleep(5) with emit.pause(): print("inside") emit.message("Done") ``` and ``` emit.progress("Long text") time.sleep(5) ``` In the first case the text `inside` should overwrite "Long text", and in the second case whatever comes next because the process ends (e.g. the shell prompt) it should overwrite "Long text". IOW, "Long text" should not remain in the screen after "the next thing comes" (because it's transient progress).

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha
Impact: 30
Quick Win: 18
Complexity: 30
Confidence: 90
Actionability: 85
close resolved Reporter (maintainer facundobatista) asked the Printer to clear the transient progress line when stopping or pausing. Implemented in PR #126 (commit 9f9df27, merged as 2cbced2); issue left open.
qwen/qwen3.6-35b-a3b
Impact: 30
Quick Win: 19
Complexity: 20
Confidence: 90
Actionability: 80
close resolved Issue about cleaning transient progress lines on stop/pause. Resolved by merged PR #126 which enhanced ephemeral message handover in the Printer class.
qwen/qwen3.8-27b
Impact: 30
Quick Win: 18
Staleness: 55
Complexity: 40
Confidence: 60
Support Request: 0
keep open Printer leaves transient progress text on screen when stopping or pausing; it should be overwritten by the next output. Open since 2022, no comments, but a related fix (PR #126) already enhanced ephemeral handover after pause/stop.
qwen/qwen3.6-35b-a3b
Staleness: 92
Complexity: 35
Confidence: 75
Support Request: 10
close stale Console printer fails to clear transient progress lines on stop or pause, leaving leftover text on the terminal. Issue has been inactive for over 3 years with no comments or reproduction steps.
qwen3.6-35b-a3b-mtp-q6
Staleness: 85
Complexity: 20
Confidence: 75
Support Request: 5
needs triage Printer leaves transient progress text on screen when stopped or paused. The report includes code examples but has no labels, comments, or maintainer response after over three years.

Update history

No update history recorded yet.

Related work

  • Likely Fixed By: canonical/craft-cli#126 (confidence 95%)

    PR 'enhance-transient-emit-pause' (commit 9f9df27, merged as 2cbced2) enhances ephemeral message handover in the Printer after pause() or stop() — both cases named in the issue.

Related issues

Issue Project State Summary Similarity
#445 fix(printer): handle multiline permanent progress correctly craft-cli merged Merged PR #445 in commit 690c523, fixing multiline permanent progress to clear every terminal line and log multiline text as separate timestamped lines.
71%