fix new printer for logging handler
Metadata
Current evaluation
Merged as 585f41d; emit.pause() now refreshes the logging handler's printer when creating its replacement, fixing #139.
Resolution: closed resolved
Reason: PR #140 was approved and merged as commit 585f41d. Its change ensures the recreated logging handler uses the replacement printer, resolving #139.
Evaluated by: mr-cal-bot
No scores available.
Issue body
I'm not sure if this is the best solution here or we should use something like `printer.start` / `printer.recreate`.
I also think some unit tests would be nice and will add them if this solution is approved.
fixes: #139
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged as 585f41d; emit.pause() now refreshes the logging handler's printer when creating its replacement, fixing #139. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #140 as commit 585f41d, updating the logging handler to use the replacement Printer after emit.pause() and fixing #139. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged as commit 585f41d: emit.pause() now also assigns the freshly created Printer to self._log_handler.printer, so logging writes to the current printer. Fixes issue #139. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in canonical/craft-cli#140 as commit 585f41d, updating the logging handler when emit.pause() creates a new printer and fixing #139. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged a one-line fix updating the logging handler to use the new emitter printer, resolving the logging problem in #139 (commit 585f41d). | |
| stealth/space-bunny-alpha | — | closed resolved | Merged a one-line update to assign emit.pause()'s new printer to the logging handler, fixing canonical/craft-cli#139. Merged as commit 585f41d. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in canonical/craft-cli#140 (585f41d), updating the logging handler when emit.pause creates a new printer and fixing #139. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged a one-line fix for the new printer in the logging handler, resolving issue #139. Approved by one reviewer, the change required two reopenings to pass CI tests and linting before final merge. |
Update history
No update history recorded yet.
Related work
-
Likely Fixed By:
canonical/craft-cli#139
(confidence 100%)
PR #140 fixes the logging-handler printer problem reported in issue #139.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #139 emit.pause is creating new Printer, but not updating printer for logging | craft-cli | closed | Fixed in canonical/craft-cli#140, merged as commit 585f41d; emit.pause() now assigns the replacement printer to the logging handler. |