← Back to issue list

tests: move test module from unit/ to integration/

View original Github issue

Metadata

Project
craft-cli
Number
#167
Type
pull request
State
merged
Author
tigarmo
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #167 (commit 76e99ec) moved test_messages_integration from tests/unit/ to tests/integration/ and widened coverage collection to include integration tests.

Resolution: closed resolved

Reason: The PR was approved and merged as commit 76e99ec ("tests: move test module from unit/ to integration/"), which created tests/integration/test_messages_integration.py. Per the review discussion with lengau, a follow-up commit in the same PR enabled coverage for integration tests, now reflected in the coverage source config.

Evaluated by: mr-cal-bot

No scores available.

Issue body

The test_messages_integration module, as the name implies, contains a lot of integration-level tests with little-to-no mocking. For clarity's sake and to keep consistent with the other Craft libraries, move the module to the integration/ folder (which is under-represented anyway). - [ ] Have you followed the guidelines for contributing? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `tox`?

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #167 (commit 76e99ec) moved test_messages_integration from tests/unit/ to tests/integration/ and widened coverage collection to include integration tests.
stealth/space-bunny-alpha — closed resolved Merged PR #167 (76e99ec), moving test_messages_integration from unit/ to integration/ and enabling coverage reporting for integration tests.
qwen/qwen3.6-35b-a3b — — Merged the move of test_messages_integration from unit/ to integration/. Updated coverage to include integration tests, disabled the local fail_under check, and relies on GitHub coverage. Approved and passed CI.

Update history

No update history recorded yet.

Related issues

No related issues found above the similarity threshold.