← Back to issue list

tests: move test module from unit/ to integration/

View original Github issue

Metadata

Project
craft-cli
Number
#167
Type
pull request
State
merged
Author
tigarmo
Labels
Created
Updated
Closed

Current evaluation

Merged the move of test_messages_integration from unit/ to integration/. Updated coverage to include integration tests, disabled the local fail_under check, and relies on GitHub coverage. Approved and passed CI.

Suggested action:

No scores available.

Issue body

The test_messages_integration module, as the name implies, contains a lot of integration-level tests with little-to-no mocking. For clarity's sake and to keep consistent with the other Craft libraries, move the module to the integration/ folder (which is under-represented anyway). - [ ] Have you followed the guidelines for contributing? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `tox`?

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged the move of test_messages_integration from unit/ to integration/. Updated coverage to include integration tests, disabled the local fail_under check, and relies on GitHub coverage. Approved and passed CI.
qwen3.6-35b-a3b-mtp-q6 Merged to move integration tests from unit/ to integration/. Updated coverage configuration to include integration tests and disabled the local coverage threshold, relying on GitHub integration for validation.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#82 test: improve integration testing craft-store merged Merged improvements to integration testing across eight files. The update works around external fork credential limitations by running full tests only after merging to main. Approved by one reviewer and passed CI.
73%
#60 tests: move test data to a common location craft-archives merged Merged following reviewer approval and passing CI. Relocates test data to a common directory, resolving issue #39. Modifies 13 files with zero coverage impact.
72%
#107 ci: separate unit and integration tests starbase merged Merged into main after approval and passing CI checks. The PR separated unit and integration tests in the CI pipeline, modifying two files (+46/-7 lines). Code coverage remained unchanged at 100%.
72%
#278 tests: additional tests to improve coverage fetch-service merged Merged after two reviews and passing CI checks. Adds additional tests across ten files to improve code coverage, changing +386/-60 lines.
70%
#1787 tests: move refresh to unit folder snapcraft merged Merged a fix moving a misplaced refresh test into the unit folder. The test was previously excluded from regular runs due to the new directory structure, causing false passes. Approved by one reviewer, passed CI, and merged.
70%
#3167 unit tests: move to pytest snapcraft merged Merged unit test migration from unittest to pytest. Adds pytest fixtures, updates runtests.sh to use pytest-cov, and duplicates tests for individual execution. Integration tests remain on unittest. Approved and merged after CI passed.
70%