← Back to issue list

fix: clear prefix for message() and error()

View original Github issue

Metadata

Project
craft-cli
Number
#203
Type
pull request
State
merged
Author
tigarmo
Labels
—
Created
Updated
Closed

Current evaluation

Merged #203 via commits 9cdb9ef and 256d8c2, routing progress-clearing carriage returns correctly and clearing streaming-brief prefixes before message() and error().

Resolution: closed resolved

Reason: PR #203 was merged with 9cdb9ef correcting carriage-return stream routing and 256d8c2 clearing ephemeral progress prefixes. The merged changes explicitly fix issue #202.

Evaluated by: mr-cal-bot

No scores available.

Issue body

The first commit fixes a bug I bumped into where an `emit.progress()` followed by an `emit.message()` would send the carriage return (to clear the ephemeral progress) to the wrong stream. The second commit then does the actual clearing of the prefix. Fixes #202

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged #203 via commits 9cdb9ef and 256d8c2, routing progress-clearing carriage returns correctly and clearing streaming-brief prefixes before message() and error().
stealth/space-bunny-alpha — closed resolved Merged #203, fixing #202: carriage returns are routed correctly and message()/error() clear streaming-brief progress prefixes (9cdb9ef, 256d8c2).
qwen/qwen3.6-35b-a3b — — Merged fix for issue #202 correcting a bug where progress and message emissions routed carriage returns to the wrong stream. Changes clear prefixes for message() and error(), passed CI, received two approvals, and improved test coverage.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/craft-cli#202 (confidence 100%)

    PR #203 states that its merged changes fix the streaming-brief prefix problem reported in #202.

Related issues

Issue Project State Summary Similarity
#202 In "streaming brief" mode, `emit.message()` should clean the progress prefix craft-cli closed Fixed in commit 256d8c2: emit.message() and emit.error() now clear the terminal prefix in streaming brief mode, preventing output such as "Hi :: Done!".
76%