← Back to issue list

fix: clear prefix for message() and error()

View original Github issue

Metadata

Project
craft-cli
Number
#203
Type
pull request
State
merged
Author
tigarmo
Labels
Created
Updated
Closed

Current evaluation

Merged fix for issue #202 correcting a bug where progress and message emissions routed carriage returns to the wrong stream. Changes clear prefixes for message() and error(), passed CI, received two approvals, and improved test coverage.

Suggested action:

No scores available.

Issue body

The first commit fixes a bug I bumped into where an `emit.progress()` followed by an `emit.message()` would send the carriage return (to clear the ephemeral progress) to the wrong stream. The second commit then does the actual clearing of the prefix. Fixes #202

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged fix for issue #202 correcting a bug where progress and message emissions routed carriage returns to the wrong stream. Changes clear prefixes for message() and error(), passed CI, received two approvals, and improved test coverage.
qwen3.6-35b-a3b-mtp-q6 Merged fix for #202 that corrects carriage return routing when progress is followed by message or error calls, and properly clears output prefixes. Test coverage increased to 94.76%.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#4461 fix: improve lifecycle messages snapcraft merged Merged after approval and passing CI. The change improves lifecycle messages by refactoring progress emission from open_stream to explicit progress calls, maintaining code coverage.
75%
#937 fix: remove captured message on error craft-parts merged Merged a fix that removes a captured message on error. The change deletes three lines across two files, passed CI checks, received approval from two reviewers, and was successfully integrated.
74%