chore(deps): drop Pydantic dependency
Metadata
Current evaluation
PR #207 by tigarmo removed the unused Pydantic dependency from craft-cli's build config (+0/-3 lines across 3 files) and closed issue #201. Merged as commit ce2ee08 after approval from 2 reviewers; Codecov reported no coverage change.
Resolution: closed resolved
Reason: The PR was merged into main as commit ce2ee08 ("chore(deps): drop Pydantic dependency") with2 approving reviewers and no unresolved comments, and it explicitly states "Fixes #201", closing that issue.
Evaluated by: mr-cal-bot
No scores available.
Issue body
We don't use the library at all - probably what happened is that we copied the deps from somewhere else.
Fixes #201
- [ ] Have you followed the guidelines for contributing?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `tox`?
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | PR #207 by tigarmo removed the unused Pydantic dependency from craft-cli's build config (+0/-3 lines across 3 files) and closed issue #201. Merged as commit ce2ee08 after approval from 2 reviewers; Codecov reported no coverage change. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #207 removed the unused Pydantic dependency from three files, resolving #201; merged as commit ce2ee08. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #207 as commit ce2ee08, removing the unused Pydantic dependency and fixing #201 without reducing reported coverage. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged changes remove the unused Pydantic dependency, resolving issue #201. Approved by two reviewers, passed CI checks, and reduced code by three lines across three files without impacting the 94.76% test coverage. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/craft-cli#201
(confidence 98%)
"do we need Pydantic?" — closed by this PR per its "Fixes #201" line
-
Likely Fixed By:
craft-cli@ce2ee08
(confidence 97%)
Merged commit removing pydantic from the dependency declarations (pickaxe-confirmed removal)
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #370 chore(deps): update dependency pydantic to v2 | craft-providers | closed | Renovate pydantic v2 bump closed unmerged by mr-cal to defer migration to a larger craft effort; the upgrade later landed in merged PR #451 (commit f380a9e) for 2.0. | |
| #206 chore(deps): update development dependencies (non-major) | craft-cli | merged | Renovate PR updating craft-cli dev dependencies (pytest 7.4.2→7.4.3, black 23.10.0→23.11.0, yamllint 1.32.0→1.33.0, mypy 1.6.1→1.7.1, pyright 1.1.332→1.1.337) was approved and merged into main as commit 70d8914. | |
| #794 chore: remove pydantic warnings | craft-parts | merged | Merged as commit 5c1c7dd3, incorporating craft-archives PR #122 (commit 00b9b3b) to eliminate Pydantic deprecation warnings. | |
| #410 chore(deps): update development dependencies (non-major) | craft-providers | merged | Renovate bot PR updating craft-providers dev/lint/type dependencies (coverage 7.3.1, pyfakefs 5.2.4, pytest 7.4.2, typeshed stubs, black 23.9.1, mypy 1.5.1) was approved and merged as commit 93a04f2. | |
| #28 chore(deps): update dependency pydantic to v2 - autoclosed | craft-grammar | closed | Renovate's Pydantic 2 bump was closed unmerged and superseded by dedicated migration PR #33, which landed in commit 5e225fb. | |
| #68 chore(deps): update dependency pydantic_core to v2.27.2 - autoclosed | imagecraft | closed | Renovate's pydantic_core 2.27.2 bump in #68 was autoclosed unmerged after inactivity; no resolving commit or replacement PR was identified. | |
| #960 chore(deps): update dependency pydantic to v1.10.4 | charmcraft | closed | Closed unmerged: craft-parts 1.17.1 pinned pydantic 1.9.0, blocking 1.10.4; no Charmcraft commit shipped the update. | |
| #122 chore: eliminate pydantic warnings | craft-archives | merged | Merged PR #122 eliminated Pydantic warnings, landing as commit 00b9b3b after approval by two reviewers. | |
| #1351 chore(deps): update dependency pydantic to v2 | charmcraft | closed | Renovate PR bumping pydantic 1.10.13 -> 2.4.2 was closed unmerged by lengau ("will need its own project"). The upgrade later landed via PR #1777 (70078b03), merged to main in #1817 (394e6e55). | |
| #778 chore: pydantic 2 related cleanup | craft-parts | merged | Merged Pydantic 2 cleanup across seven files in commit 68d61fa0, following prerequisite plugin-model restructuring in #775. |