← Back to issue list

fix: make repeated text keep the spinner

View original Github issue

Metadata

Project
craft-cli
Number
#209
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #209 (commit 8b61db8) fixed #138 by keeping the spinner active when repeated text is received, with regression tests.

Resolution: closed resolved

Reason: PR #209 was approved and merged, and resolving commit 8b61db8 changes printer behavior so identical repeated text no longer stops the spinner. Tests cover the behavior.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Fixes #138 - [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `tox`?

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #209 (commit 8b61db8) fixed #138 by keeping the spinner active when repeated text is received, with regression tests.
stealth/space-bunny-alpha — closed resolved Merged PR #209 (commit 8b61db8) fixed repeated same-text progress messages by keeping the spinner active, resolving issue #138.
stealth/space-bunny-alpha — closed resolved Merged PR #209 (commit 8b61db8) fixes #138 by keeping the spinner active when the same text is repeated, with tests covering the change.
qwen/qwen3.6-35b-a3b — — Merged to fix issue #138, ensuring repeated text updates retain the spinner. Approved by two reviewers, passed CI checks, and improved test coverage. The change modified three files with 179 additions and 20 deletions.

Update history

No update history recorded yet.

Related work

Related issues

Issue Project State Summary Similarity
#138 Repeated same-text message makes the spinner and elapsed time look weird craft-cli closed Closed without a linked PR, commit, version, or maintainer explanation; the repeated-progress spinner and elapsed-time behavior was not formally resolved.
71%