fix: remove trailing spaces where supported
Metadata
Current evaluation
Merged as c62ce3a; the printer now removes trailing spaces before line breaks on supported terminals, fixing #136 (CRAFT-3358).
Resolution: closed resolved
Reason: PR #210 was merged into the main branch as commit c62ce3a, resolving issue #136 with terminal-aware trailing-space removal and updated tests.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Fixes #136
CRAFT-3358
- [x] Have you followed the guidelines for contributing?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `tox`?
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged as c62ce3a; the printer now removes trailing spaces before line breaks on supported terminals, fixing #136 (CRAFT-3358). | |
| stealth/space-bunny-alpha | — | closed resolved | Merged to main as commit c62ce3a, stripping trailing spaces before newlines on terminals that support it; fixes #136 (CRAFT-3358). Follow-up #275 added cursor hiding. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #210 as c62ce3a, removing trailing spaces before line breaks on supported terminals and fixing #136. Follow-up #275 addressed cursor hiding and restoration. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in canonical/craft-cli#210 as commit c62ce3a, removing trailing spaces where supported to fix #136. Follow-up #275 addressed cursor visibility. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged to remove trailing spaces where supported. Approved by two reviewers and passed CI checks. Modified three files. A follow-up PR was created to address cursor jumping behavior noted during review. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/craft-cli#136
(confidence 100%)
The issue requesting removal of trailing spaces before line breaks was fixed by PR #210.
-
Related To:
canonical/craft-cli#275
(confidence 98%)
Follow-up PR #275, merged as 9dfc386, added cursor hiding and restoration to complement the output behavior.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #136 Remove trailing spaces before new line | craft-cli | closed | Craft-CLI output now removes trailing spaces where supported, fixing copy-and-paste padding in PR #210 (commit c62ce3a). |