fix: only greet once when setting the same mode
Metadata
Current evaluation
Merged #301 in commit 6fa01e1, making Emitter.set_mode a no-op for an unchanged mode so verbose/debug startup greetings are not duplicated.
Resolution: closed resolved
Reason: Pull request #301 was merged with approval from two reviewers. Commit 6fa01e1 adds an early return when the requested emitter mode already matches, preventing a second greeting.
Evaluated by: mr-cal-bot
No scores available.
Issue body
With this fix, ``Emitter.set_mode(mode)`` becomes a no-op if the emitter is already at that ``mode``. This scenario can happen, for example, if the Emitter is initialized with a mode and then the Dispatcher sets the same mode during command-line handling.
- [ ] Have you followed the guidelines for contributing?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `tox`?
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged #301 in commit 6fa01e1, making Emitter.set_mode a no-op for an unchanged mode so verbose/debug startup greetings are not duplicated. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged fix makes Emitter.set_mode a no-op when the mode is unchanged, preventing duplicate greetings when the dispatcher reapplies the initial mode. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged a fix preventing duplicate greetings by making Emitter.set_mode a no-op when the mode is already active. Approved by two reviewers, passed CI, and implemented across three files with 36 lines of code. |
Update history
No update history recorded yet.
Related issues
No related issues found above the similarity threshold.