← Back to issue list

fix: don't suggest hidden commands

View original Github issue

Metadata

Project
craft-cli
Number
#302
Type
pull request
State
merged
Author
tigarmo
Labels
—
Created
Updated
Closed

Current evaluation

Merged in canonical/craft-cli#302 (commit 4be3f0c), preventing hidden commands from appearing in command-not-found suggestions and fixing #297.

Resolution: closed resolved

Reason: The approved PR was merged as commit 4be3f0c. Its implementation filters hidden commands from suggestions and explicitly fixes canonical/craft-cli#297.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Fixes #297 - [ ] Have you followed the guidelines for contributing? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `tox`?

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged in canonical/craft-cli#302 (commit 4be3f0c), preventing hidden commands from appearing in command-not-found suggestions and fixing #297.
stealth/space-bunny-alpha — closed resolved Merged canonical/craft-cli#302 (commit 4be3f0c) fixes #297 by excluding hidden commands from invalid-command suggestions; shipped in version 2.10.1.
stealth/space-bunny-alpha — closed resolved Merged PR #302 as commit 4be3f0c, filtering hidden commands out of command-not-found suggestions and fixing #297.
stealth/space-bunny-alpha — closed resolved Merged in canonical/craft-cli#302 (commit 4be3f0c), preventing hidden commands from being suggested when a command is not found.
qwen/qwen3.6-35b-a3b — — Merged to resolve issue #297 by preventing hidden command suggestions. Approved by two reviewers, passed CI checks, and updated three files with a +26/-1 line change.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/craft-cli#297 (confidence 100%)

    Reported hidden commands being suggested for an unknown command; PR #302 explicitly states that it fixes this issue.

  • Related To: canonical/craft-cli#452 (confidence 90%)

    Later change titled "fix: don't recommend hidden commands" addressed the same suggestion-filtering behavior.

Related issues

Issue Project State Summary Similarity
#452 fix: don't recommend hidden commands craft-cli merged Merged PR #452 via commit 574d243 fixes CRAFT-5213 by excluding hidden commands from “See also” recommendations in command help, resolving issue #449.
84%
#297 Hidden commands are suggested as alternatives for command not found craft-cli closed Hidden-command suggestions were fixed in merged PR #302 (commit 4be3f0c), filtering hidden commands out of command-not-found alternatives.
72%