Remove black
Metadata
Current evaluation
Merged PR #305 (commit 4837258), removing the Python Black package due to Python 3.8 incompatibility in favor of the Snap executable; Ruff also reformatted code.
Resolution: closed resolved
Reason: PR #305 was merged as commit 4837258, updating pyproject.toml and tox.ini to use Snap-based Black and applying Ruff formatting. This resolved the unsupported Python Black package problem.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [ ] Have you followed the guidelines for contributing?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `tox`?
The version of black was not supported with Python 3.8, the alternative was to switch to the snap version of black.
The commit affecting pyproject.toml and tox.ini is transposed from https://github.com/canonical/charmcraft/commit/d2b40dfbece3e9cc8577c19407c2dedbc30e9d2f and https://github.com/canonical/charmcraft/commit/9583793226b73478b9af24d649f0c1ca2b83c9bb with the exception of the ISC ignore in pyproject.toml
The second commit is a result of the ruff formatting
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #305 (commit 4837258), removing the Python Black package due to Python 3.8 incompatibility in favor of the Snap executable; Ruff also reformatted code. | |
| stealth/space-bunny-alpha | — | closed resolved | Removed Black in merged PR #305 (commit 4837258) because it did not support Python 3.8; ported configuration changes from Charmcraft and adopted Ruff formatting. | |
| qwen/qwen3.6-35b-a3b | — | — | Removed the black dependency due to Python 3.8 incompatibility, replacing it with ruff for code formatting. The change was transposed from charmcraft, approved by two reviewers, and merged after passing CI checks. |
Update history
No update history recorded yet.
Related work
-
Related To:
craft-cli#363
(confidence 95%)
Later PR #363 removed remaining Black usage in favor of Ruff, merged as commit e583ec8.
Related issues
No related issues found above the similarity threshold.