← Back to issue list

logger pollutes strings with white spaces

View original Github issue

Metadata

Project
craft-cli
Number
#338
Type
pull request
State
open
Author
dariuszd21
Labels
Created
Updated
Closed

Current evaluation

Fixes broken output when streaming_brief=True and log entries contain whitespace (\n, \t). Small 1-file fix (+22/-1). Pending review, CI failing on linters and ubuntu-20.04, codecov 399 commits behind main.

Suggested action: needs review

Reason: The PR targets a still-present feature (streaming_brief in craft_cli/messages.py) but has 0 reviewers, failing linter and ubuntu-20.04 CI checks, and the codecov report is 399 commits behind main. The author is a maintainer (dariuszd21) who should address the lint failures and rebase before a maintainer can review.

Impact: 35 Quick Win: 29.75 Staleness: 55 Complexity: 15 Confidence: 75

Issue body

- [ ] Have you followed the guidelines for contributing? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `tox`? If `streaming_brief=True` is set for Emitter and there is log entry (`log.info()`) before message that has white space characters inside (e.g `\n`, `\t`), output is broken.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.8-27b
Impact: 35
Quick Win: 29.75
Staleness: 55
Complexity: 15
Confidence: 75
needs review Fixes broken output when streaming_brief=True and log entries contain whitespace (\n, \t). Small 1-file fix (+22/-1). Pending review, CI failing on linters and ubuntu-20.04, codecov 399 commits behind main.
qwen/qwen3.6-35b-a3b
Staleness: 65
Complexity: 15
Confidence: 55
needs review Fixes logger output corruption when streaming_brief is enabled and log entries contain whitespace. Currently pending review with 0 approvals and failing linter/Ubuntu 20.04 tests. Last updated 107 days ago.
qwen3.6-35b-a3b-mtp-q6
Staleness: 75
Complexity: 20
Confidence: 65
needs review Fixes broken output when streaming_brief is enabled and log entries contain whitespace characters. PR is inactive for ~3 months with no maintainer feedback.
qwen3.6-35b-a3b-mtp-q6
Staleness: 45
Complexity: 20
Confidence: 75
needs review Fixes a logger bug that corrupts output with unwanted whitespace when streaming_brief is enabled and log entries contain escape characters. Tests pass with 93.97% coverage, but the pull request has been inactive for 72 days and requires maintainer review.

Update history

No update history recorded yet.

Related issues

No related issues found above the similarity threshold.