← Back to issue list

logger pollutes strings with white spaces

View original Github issue

Metadata

Project
craft-cli
Number
#338
Type
pull request
State
open
Author
dariuszd21
Labels
—
Created
Updated
Closed
—

Current evaluation

Fixes newline/tab corruption in ephemeral BRIEF logger output; the unreviewed branch is 399 commits behind main and has failing linters and Ubuntu 20.04 tests.

Suggested action: needs review

Reason: The current _Handler.emit still passes raw record.getMessage() into ephemeral output, so the reported bug path appears unresolved on main; #445 only addresses later multiline handling for permanent progress. The change is small and Codecov reports modified-line coverage, but the 399-commit-behind branch, failed linters and Ubuntu 20.04 tests require a refresh and CI rerun before final review.

Evaluated by: mr-cal-bot

Impact: 41 Quick Win: 8 Complexity: 32 Confidence: 76 Actionability: 28

Issue body

- [ ] Have you followed the guidelines for contributing? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `tox`? If `streaming_brief=True` is set for Emitter and there is log entry (`log.info()`) before message that has white space characters inside (e.g `\n`, `\t`), output is broken.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha
Impact: 41
Quick Win: 8
Complexity: 32
Confidence: 76
Actionability: 28
needs review Fixes newline/tab corruption in ephemeral BRIEF logger output; the unreviewed branch is 399 commits behind main and has failing linters and Ubuntu 20.04 tests.
qwen/qwen3.6-35b-a3b
Impact: 45
Quick Win: 11
Complexity: 20
Confidence: 55
Actionability: 30
keep open Fixes broken output when streaming_brief=True and log entries contain whitespace characters. Small 1-file fix (+22/-1). Pending review, CI failing on linters and ubuntu-20.04.
qwen/qwen3.8-27b
Impact: 35
Quick Win: 30
Staleness: 55
Complexity: 15
Confidence: 75
needs review Fixes broken output when streaming_brief=True and log entries contain whitespace (\n, \t). Small 1-file fix (+22/-1). Pending review, CI failing on linters and ubuntu-20.04, codecov 399 commits behind main.
qwen/qwen3.6-35b-a3b
Staleness: 65
Complexity: 15
Confidence: 55
needs review Fixes logger output corruption when streaming_brief is enabled and log entries contain whitespace. Currently pending review with 0 approvals and failing linter/Ubuntu 20.04 tests. Last updated 107 days ago.
qwen3.6-35b-a3b-mtp-q6
Staleness: 75
Complexity: 20
Confidence: 65
needs review Fixes broken output when streaming_brief is enabled and log entries contain whitespace characters. PR is inactive for ~3 months with no maintainer feedback.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/craft-cli#445 (confidence 86%)

    Its later printer change overlaps multiline rendering, but its stated scope does not clearly cover whitespace in ephemeral log entries.

Related issues

No related issues found above the similarity threshold.