fix(printer): stop the printer on destruct
Metadata
Current evaluation
Merged PR #339 (commit b94a6b7) added destructor-based printer cleanup, ensuring the printer stops during garbage collection and the terminal cursor is restored before process exit; fixes #334.
Resolution: closed resolved
Reason: craft-cli#339 was merged as commit b94a6b7. It stops an unstopped printer during garbage collection and explicitly resolves craft-cli#334.
Evaluated by: mr-cal-bot
No scores available.
Issue body
This stops the printer when garbage collecting it, even if it hasn't been manually stopped. This stops the printer before exiting the process no matter what.
Fixes #334
- [x] Have you followed the guidelines for contributing?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `tox`?
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #339 (commit b94a6b7) added destructor-based printer cleanup, ensuring the printer stops during garbage collection and the terminal cursor is restored before process exit; fixes #334. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged craft-cli#339 as b94a6b7, adding printer shutdown on garbage collection to ensure it stops before process exit and fixing #334. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged a fix that stops the printer on garbage collection to prevent lingering processes, resolving issue #334. Approved by two reviewers and passed CI checks. |
Update history
No update history recorded yet.
Related work
-
Likely Fixed By:
canonical/craft-cli#334
(confidence 100%)
PR #339 explicitly fixes the cursor-restoration failure reported in issue #334.
Related issues
No related issues found above the similarity threshold.