fix: filter other commands by name instead of type
Metadata
Current evaluation
Fixes 'See also' help section incorrectly omitting parent commands by comparing command names instead of using isinstance. 396 days old, CI green, 0 reviewers, author asked an unanswered question about the test.
Suggested action: needs review
Reason: The bug is still present in craft_cli/helptexts.py line 479 (isinstance check on command classes), CI is fully green, and the fix is a trivial 8-line change. However, 0 reviewers have engaged in 396 days and the author's question about whether the regression test is worthwhile (2025-08-05) remains unanswered, so a maintainer needs to review and address that before merging.
Impact:
20
Quick Win:
18.0
Staleness:
65
Complexity:
10
Confidence:
78
Issue body
Previously, a command like craft_appplication.command.TestCommand, which inherits from PackCommand, would omit the parent command in the "see also" section.
- [x] Have you followed the guidelines for contributing?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `make lint && make test`?
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.8-27b |
Impact:
20
Quick Win:
18.0
Staleness:
65
Complexity:
10
Confidence:
78
|
needs review | Fixes 'See also' help section incorrectly omitting parent commands by comparing command names instead of using isinstance. 396 days old, CI green, 0 reviewers, author asked an unanswered question about the test. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
88
Complexity:
12
Confidence:
72
|
close stale | Fixes command filtering to use name instead of type, resolving an omission of inherited commands in the see also section. All CI passes, but the PR has been inactive for over 8 months with no reviewer feedback. | |
| qwen3.6-35b-a3b-mtp-q6 |
Staleness:
80
Complexity:
20
Confidence:
75
|
close stale | Fixes command filtering logic to use name instead of type, resolving a see also omission for inherited commands. Unreviewed and inactive for 247 days. | |
| qwen3.6-35b-a3b-mtp-q6 |
Staleness:
75
Complexity:
20
Confidence:
70
|
close stale | Fixes see also command filtering by matching names instead of types, resolving an omission bug for inherited commands. PR remains open with no maintainer activity since 226 days ago. Author questions if the regression test is needed. |
Update history
No update history recorded yet.
Related issues
No related issues found above the similarity threshold.