← Back to issue list

fix: filter other commands by name instead of type

View original Github issue

Metadata

Project
craft-cli
Number
#369
Type
pull request
State
open
Author
jonathan-conder
Labels
—
Created
Updated
Closed
—

Current evaluation

Changes command help’s “See also” filtering from subclass/type checks to name comparison, fixing inherited commands that omit their parent. All CI checks pass, but maintainer review is still pending.

Suggested action: needs review

Reason: The +8/-4, three-file change is narrowly scoped, and the supplied status shows all CI checks passing with no unresolved comments. It is still awaiting its first maintainer reviewer after 333 days without activity, while the author questioned the regression test’s long-term relevance, so it needs review rather than being closed as merely stale.

Evaluated by: mr-cal-bot

Impact: 25 Quick Win: 16 Complexity: 18 Confidence: 88 Actionability: 78

Issue body

Previously, a command like craft_appplication.command.TestCommand, which inherits from PackCommand, would omit the parent command in the "see also" section. - [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint && make test`?

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha
Impact: 25
Quick Win: 16
Complexity: 18
Confidence: 88
Actionability: 78
needs review Changes command help’s “See also” filtering from subclass/type checks to name comparison, fixing inherited commands that omit their parent. All CI checks pass, but maintainer review is still pending.
qwen/qwen3.6-35b-a3b
Impact: 30
Quick Win: 22
Complexity: 10
Confidence: 75
Actionability: 80
needs review Fixes 'see also' section in command help to filter by name instead of type, preventing parent commands from being incorrectly omitted when child commands inherit from them. CI passing, awaiting review.
qwen/qwen3.8-27b
Impact: 20
Quick Win: 18
Staleness: 65
Complexity: 10
Confidence: 78
needs review Fixes 'See also' help section incorrectly omitting parent commands by comparing command names instead of using isinstance. 396 days old, CI green, 0 reviewers, author asked an unanswered question about the test.
qwen/qwen3.6-35b-a3b
Staleness: 88
Complexity: 12
Confidence: 72
close stale Fixes command filtering to use name instead of type, resolving an omission of inherited commands in the see also section. All CI passes, but the PR has been inactive for over 8 months with no reviewer feedback.
qwen3.6-35b-a3b-mtp-q6
Staleness: 80
Complexity: 20
Confidence: 75
close stale Fixes command filtering logic to use name instead of type, resolving a see also omission for inherited commands. Unreviewed and inactive for 247 days.

Update history

No update history recorded yet.

Related issues

No related issues found above the similarity threshold.