feat: make report_error public
Metadata
Current evaluation
Merged PR craft-cli#381 (commit 8103c35, CRAFT-4703) made Emitter.report_error() public so errors can be printed without stopping the emitter; shipped in 3.2.0. Unblocked craft-application#897.
Resolution: closed resolved
Reason: The PR itself was merged into main as commit 8103c35 ("feat: make report_error public (#381)"), renaming the private helper to a public Emitter.report_error() in craft_cli/messages.py and documenting it in docs/changelog.rst under 3.2.0. Its stated consumer, craft-application#897, was merged and notes the feature is "enabled by canonical/craft-cli#381".
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [ ] Have you followed the guidelines for contributing?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `make lint && make test`?
---
Exposes the `report_error` function to allow printing an error without immediately terminating the emitter.
Required by https://github.com/canonical/craft-application/pull/897.
CRAFT-4703.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR craft-cli#381 (commit 8103c35, CRAFT-4703) made Emitter.report_error() public so errors can be printed without stopping the emitter; shipped in 3.2.0. Unblocked craft-application#897. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged craft-cli#381 (8103c35), making report_error public so callers can print errors without terminating emitters, enabling canonical/craft-application#897. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged into craft-cli via #381 (commit 8103c35), making report_error public so callers can print errors without immediately terminating the emitter. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #381 (commit 8103c35), making report_error public so callers can print errors without terminating the emitter. All CI checks passed. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged canonical/craft-cli#381 to expose report_error publicly, allowing errors to be printed without immediately terminating the emitter. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged to expose the report_error function publicly, allowing error printing without terminating the emitter. Approved by three reviewers with all CI checks passing. The change modifies three files, adding 14 lines and removing 3. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/craft-application#897
(confidence 95%)
Downstream PR explicitly requiring this change; merged and cites craft-cli#381 as enabling it.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #432 feat: rust error emitting | craft-cli | merged | Merged in canonical/craft-cli#432, restoring error() and report_error() to the Rust Emitter. |