pylint shows some warnings
Metadata
Current evaluation
Pylint warnings were fixed and pylint was enforced in GitHub CI by merged PR #59 (commit ad06d5c; merge 6dafc86).
Resolution: closed resolved
Reason: PR #59 was merged to resolve the lint gap, adding pylint to GitHub CI in commit ad06d5c through merge commit 6dafc86.
Evaluated by: mr-cal-bot
No scores available.
Issue body
```
$ make lint
black --check --diff setup.py examples.py craft_cli tests
All done! ✨ 🍰 ✨
14 files would be left unchanged.
codespell setup.py examples.py craft_cli tests
flake8 setup.py examples.py craft_cli tests
isort --check setup.py examples.py craft_cli tests
mypy setup.py examples.py craft_cli tests
Success: no issues found in 14 source files
pydocstyle craft_cli
pylint craft_cli
************* Module craft_cli.messages
craft_cli/messages.py:591:24: R1714: Consider merging these comparisons with "in" to 'self.mode in (EmitterMode.VERBOSE, EmitterMode.TRACE)' (consider-using-in)
craft_cli/messages.py:683:11: R1714: Consider merging these comparisons with "in" to 'self._mode in (EmitterMode.VERBOSE, EmitterMode.TRACE)' (consider-using-in)
craft_cli/messages.py:703:30: R1714: Consider merging these comparisons with "in" to 'self._mode in (EmitterMode.VERBOSE, EmitterMode.TRACE)' (consider-using-in)
craft_cli/messages.py:766:11: R1714: Consider merging these comparisons with "in" to 'self._mode in (EmitterMode.QUIET, EmitterMode.NORMAL)' (consider-using-in)
craft_cli/messages.py:786:11: R1714: Consider merging these comparisons with "in" to 'self._mode in (EmitterMode.QUIET, EmitterMode.NORMAL)' (consider-using-in)
------------------------------------------------------------------
Your code has been rated at 9.87/10 (previous run: 9.87/10, -0.00)
make: *** [Makefile:94: test-pylint] Error 8
```
Looks like `pylint` is not enforced by CI.
So I think it would make sense to either remove `pylint` also from `make lint` / `tox -e lint` or enforce it via CI.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Pylint warnings were fixed and pylint was enforced in GitHub CI by merged PR #59 (commit ad06d5c; merge 6dafc86). | |
| stealth/space-bunny-alpha | — | closed resolved | Pylint was added to GitHub CI by merged PR #59 (commit ad06d5c), resolving the mismatch between local lint failures and unenforced CI checks. | |
| stealth/space-bunny-alpha | — | closed resolved | Resolved by merged PR #59 (commit ad06d5c), which added Pylint to GitHub CI; merge commit 6dafc86. | |
| stealth/space-bunny-alpha | — | closed resolved | Pylint was enforced in GitHub CI by merged PR #59 (ad06d5c), addressing warnings that were checked locally but not in CI. | |
| qwen/qwen3.6-35b-a3b | — | — | Closed without resolution. Pylint warnings in messages.py remain unaddressed. The suggestion to either remove pylint from the lint command or enforce it in CI was abandoned. | |
| qwen/qwen3.6-35b-a3b | — | — | Closed without comments or discussion. The suggested fix to remove pylint from the lint step or enforce it in CI was not implemented, leaving the issue abandoned. | |
| qwen/qwen3.6-35b-a3b | — | — | Closed without discussion. The pylint warnings were addressed by removing pylint from the lint command, as CI did not enforce it. |
Update history
No update history recorded yet.
Related work
-
Likely Fixed By:
canonical/craft-cli#59
(confidence 100%)
Merged PR that resolved the reported pylint warnings and CI enforcement gap.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #57 tests: update pylint and address new warnings | craft-parts | merged | Merged PR #57 in commit 78560246 upgraded pylint to 2.8.2 and addressed the resulting warnings with minor test changes. | |
| #59 Run pylint in Github CI. | craft-cli | merged | Merged PR #59 added pylint to GitHub CI via ad06d5c (merge 6dafc86); later PR #173 replaced pylint with Ruff. |