← Back to issue list

feat: error on default command

View original Github issue

Metadata

Project
craft-cli
Number
#422
Type
pull request
State
merged
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

Merged in canonical/craft-cli#422 via commit 7b630a9 and released in 3.3.0, adding configurable default-command handling to Dispatcher.

Resolution: closed resolved

Reason: PR #422 was approved and merged as commit 7b630a9. It adds Dispatcher.allow_default_command: true permits default use with a deprecation warning, while false raises an error.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint && make test`? --- Adds an `allow_default_command` parameter to the Dispatcher to allow using a default command. This is an opt-in flag, so there are no behavioral changes for existing apps. Tested downstream in https://github.com/canonical/snapcraft/pull/6074 Unblocks https://github.com/canonical/snapcraft/issues/5673 (SNAPCRAFT-1194)

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged in canonical/craft-cli#422 via commit 7b630a9 and released in 3.3.0, adding configurable default-command handling to Dispatcher.
stealth/space-bunny-alpha — closed resolved PR #422 merged (7b630a9), adding an opt-in `allow_default_command` Dispatcher parameter: False errors on bare invocation, True warns. Default True keeps existing behaviour; verified in craft_cli/dispatcher.py and changelog.
stealth/space-bunny-alpha — closed resolved Merged in craft-cli#422 via 7b630a9, adding opt-in allow_default_command support with no behavior change for existing applications.
qwen/qwen3.6-35b-a3b — — Merged. Adds opt-in allow_default_command to Dispatcher for default command support without breaking existing apps. Approved by three reviewers, passed CI, and unblocks downstream snapcraft.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/craft-cli#361 (confidence 98%)

    Tracking issue for eventual removal of default-command support; #422 provides the intermediate compatibility behavior.

  • Related To: canonical/snapcraft#6074 (confidence 98%)

    Downstream Snapcraft PR used to test the new Dispatcher option.

  • Likely Fixed By: canonical/snapcraft#5673 (confidence 95%)

    The PR body explicitly identifies #422 as unblocking this Snapcraft issue.

Related issues

Issue Project State Summary Similarity
#58 Support for a default command in Dispatcher (CRAFT-760). craft-cli merged Added and documented Dispatcher support for a default command under CRAFT-760; approved PR #58 merged into main in commit 7bc0567.
76%