← Back to issue list

feat: support units for progress bars

View original Github issue

Metadata

Project
craft-cli
Number
#428
Type
pull request
State
merged
Author
bepri
Labels
—
Created
Updated
Closed

Current evaluation

PR #428 by bepri merged (commit bca0d66), adding a `units` parameter to Emitter.progress_bar so progress bars can label units; shipped in craft-cli 3.4.0.

Resolution: closed resolved

Reason: The PR itself was merged into main as commit bca0d66 ('feat: support units for progress bars (#428)') with all CI checks passing and 3 approvals. The change landed in craft-cli 3.4.0, noted in docs/changelog.rst as the new `units` parameter for .Emitter.progress_bar.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint && make test`? --- Adds support for units in progress bars. Since more sophisticated progress bars are coming from #426, this is an intentionally simple implementation to accommodate other work until the other PR can be released. CRAFT-5029

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved PR #428 by bepri merged (commit bca0d66), adding a `units` parameter to Emitter.progress_bar so progress bars can label units; shipped in craft-cli 3.4.0.
stealth/space-bunny-alpha — closed resolved Merged #428 (bca0d66), adding unit support to progress bars as an interim implementation ahead of the more sophisticated bars in #426.
qwen/qwen3.6-35b-a3b — — Merged after approval and passing CI checks. Implements unit support for progress bars to unblock other work. Modifies six files with 120 additions and 13 deletions, including a minor fix.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/craft-cli#426 (confidence 95%)

    PR body states this intentionally simple implementation is a stopgap until the more sophisticated 'oxidized progress bars' PR #426 could be released.

  • Caused By: canonical/craft-cli#426 (confidence 55%)

    The units support was added to accommodate other work pending behind the progress-bar rework in #426.

Related issues

Issue Project State Summary Similarity
#426 feat: oxidized progress bars craft-cli merged Merged into main in canonical/craft-cli#426, implementing the redesigned Emitter.progress_bar API and oxidized progress-bar output for CRAFT-4983.
76%