fix: raise TypeError for non-string items in humanize_list
Metadata
Current evaluation
Adds TypeError check to humanize_list for non-string items, addressing issue #413. Clean diff awaiting review; only CI failure is Canonical CLA.
Suggested action: needs review
Reason: Small, focused fix (+13/-0 lines) that adds type validation to humanize_list, addressing issue #413. The diff is clean and the only CI failure is the Canonical CLA (a one-time contributor setup, not a code issue). The issue summary notes the direction was 'still unanswered' when deferred to emitter oxidation (#411), but #411 is now merged, so this PR can move forward with maintainer review.
Evaluated by: mr-cal-bot
Issue body
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b |
Impact:
30
Quick Win:
16
Complexity:
10
Confidence:
70
Actionability:
60
|
needs review | Adds TypeError check to humanize_list for non-string items, addressing issue #413. Clean diff awaiting review; only CI failure is Canonical CLA. | |
| qwen/qwen3.6-35b-a3b |
Impact:
50
Quick Win:
26
Complexity:
15
Confidence:
70
Actionability:
60
|
needs review | Adds TypeError check to humanize_list for non-string items, addressing issue #413 where non-string values were silently coerced via f-string formatting. |
Update history
| Date | Change |
|---|---|
| created |
Related work
-
Related To:
craft-cli#413
(confidence 95%)
This PR directly addresses issue #413 where humanize_list silently coerced non-string items via f-string formatting.
-
Related To:
craft-cli#411
(confidence 80%)
Issue #413 was deferred to the emitter oxidation (#411), which is now merged, removing the prior blocker.
Related issues
No related issues found above the similarity threshold.