Refactor Emitter to comply with the new verbosity levels behaviour (CRAFT-1136).
Metadata
Current evaluation
Merged PR #90 as 89b9eaa (implementation 3526a7a), refactoring Emitter toward CRAFT-1136's new verbosity behavior as part of a broader PR series.
Resolution: closed resolved
Reason: PR #90 was merged into main as 89b9eaa, with implementation commit 3526a7a. It updates Emitter and its tests for the staged CRAFT-1136 verbosity-level redesign.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Note that Emitter final behaviour (as described in the Spec) will only be achieved after more several PRs, I added XXX notes for changes that will happen in the short term future.
This branch is for sure the most "conceptual" one in the "verbosity levels" series. The changes in the code are not many, but the tests are seriously affected (and will continue to mutate when other PRs land). My recommendation is to analyze the changes in the code using [the Spec itself](https://docs.google.com/document/d/1pJDT-NE3jhkfVvDw6ba0Z3adnaQnGRi9slC9jIOqrZ4/edit) for better reasoning..
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #90 as 89b9eaa (implementation 3526a7a), refactoring Emitter toward CRAFT-1136's new verbosity behavior as part of a broader PR series. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #90 as 89b9eaa (implementation 3526a7a), refactoring Emitter toward CRAFT-1136's new verbosity behavior as part of a larger PR series. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged PR refactoring the Emitter for new verbosity levels (CRAFT-1136). Approved, passed CI, and modified four files. The conceptual changes are part of a larger series, with test updates and future spec adjustments noted. |
Update history
No update history recorded yet.
Related work
-
Related To:
craft-cli#92
(confidence 90%)
Merged follow-up in the verbosity series that added Emitter's debug and verbose methods.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #94 Refactor how the logger Handler behaves for the new verbosity levels (CRAFT-1138). | craft-cli | merged | Merged the logger Handler refactor for new verbosity levels (CRAFT-1138) in PR #94 via merge commit c9844a6; implementation commit: 738fadf. | |
| #264 Support CRAFT_VERBOSITY_LEVEL | craft-application | closed | Added CRAFT_VERBOSITY_LEVEL support to configure emitter verbosity, with invalid values falling back to BRIEF. Merged in PR #289 via commit 226fd102. | |
| #92 Added the .debug and .verbose methods to Emitter (CRAFT-1137). | craft-cli | merged | Merged PR #92 added Emitter.debug() and Emitter.verbose() for the new verbosity spec and moved pause start/end messages to debug output, visible only in TRACE mode. | |
| #88 Changed NORMAL to BRIEF and added a DEBUG verbosity level (still not used) (CRAFT-1134) | craft-cli | merged | Merged PR #88 in ffa95e8, renaming EmitterMode.NORMAL to BRIEF and adding an initially unused DEBUG level. |