← Back to issue list

feat(experimental): dictionary evaluation

View original Github issue

Metadata

Project
craft-grammar
Number
#121
Type
pull request
State
open
Author
lengau
Labels
—
Created
Updated
Closed
—

Current evaluation

Adds experimental support for evaluating grammar passed as a bare dict instead of a list (GrammarProcessor + pydantic models, +52/-14). Maintainer PR idle 188 days; lint and fast/min-dep tests failing, 4 unresolved review comments, 0 reviewers.

Suggested action: keep open

Reason: Nothing shows abandonment or obsolescence: git history for _processor.py shows no later commit implementing dictionary evaluation (subsequent work #108, #129, #130, #133, #137, #138 are unrelated features), so this is not superseded, and it is authored by a maintainer and tracked by an internal ticket (IMAGECRAFT-43). It is explicitly labeled experimental in the description, which argues for keeping it open rather than closing; however it is not actionable — 'lint / files', 'test / Fast tests (noble)', 'test / Fast tests (jammy)' and 'test / Minimum dependencies (all tests)' all fail, with 4 unresolved review comments and zero reviews after 188 days of inactivity. Confidence is moderate because I could not inspect the 4 unresolved comments or the specific test failures, so I cannot tell whether the remaining work is a small fix or a design revision.

Evaluated by: mr-cal-bot

Impact: 42 Quick Win: 4 Complexity: 57 Confidence: 70 Actionability: 22

Issue body

This is an experimental form of dictionary evaluation. Its purpose is to handle grammar even when it's not in a list. IMAGECRAFT-43 - [ ] Have you followed the guidelines for contributing? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `make lint && make test`? ---

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha
Impact: 42
Quick Win: 4
Complexity: 57
Confidence: 70
Actionability: 22
keep open Adds experimental support for evaluating grammar passed as a bare dict instead of a list (GrammarProcessor + pydantic models, +52/-14). Maintainer PR idle 188 days; lint and fast/min-dep tests failing, 4 unresolved review comments, 0 reviewers.
stealth/space-bunny-alpha
Impact: 32
Quick Win: 4
Complexity: 42
Confidence: 58
Actionability: 22
keep open Experimental dictionary evaluation in craft-grammar (GrammarProcessor), +52/-14 across 8 files, from maintainer lengau, tracking IMAGECRAFT-43. Open 394 days, 4 unresolved comments, lint and fast tests (jammy/noble) failing.
qwen/qwen3.6-35b-a3b
Impact: 30
Quick Win: 4
Complexity: 40
Confidence: 60
Actionability: 20
close stale Experimental dictionary evaluation feature for craft-grammar, draft state with unresolved review comments and failing CI, inactive for 177 days.
qwen/qwen3.8-27b
Impact: 40
Quick Win: 22
Staleness: 55
Complexity: 45
Confidence: 60
needs review Experimental dictionary evaluation for grammar handling when not in a list (IMAGECRAFT-43). Pending review, 4 unresolved comments, failing CI (lint, fast tests, min deps).
qwen/qwen3.6-35b-a3b
Staleness: 85
Complexity: 30
Confidence: 75
close stale Experimental dictionary evaluation to handle grammar outside lists. Currently pending review with zero approvals, four unresolved comments, and failing CI checks. Last updated 116 days ago.
qwen3.6-35b-a3b-mtp-q6
Staleness: 60
Complexity: 40
Confidence: 65
needs review Experimental dictionary evaluation to handle grammar outside lists. Unmerged, no comments or CI status, inactive for ~3.5 months.

Update history

No update history recorded yet.

Related work

  • Related To: IMAGECRAFT-43 (confidence 65%)

    Internal Launchpad ticket cited in the PR body as the tracker for this experimental work; external to GitHub, cannot be resolved with available tools.

Related issues

No related issues found above the similarity threshold.